[CF 1568] New Condition: Max Charges

[tmw-issue-import]

(or add an option to Spell Charges condition that you can set what the max charges for the checked spell are)

 

Would be useful for if you want to create things like activation overlays when when a spell, that can be talented to have more than the default amount of uses. 

 

IE Overpower has 1 charge, but can be talented to have two. I have an activation overlay for when it has 1 charge, but if it ever has 2 charges when I talent it, I have to either make a long conditional string w/2 parenthesis separated by an 'or' between them, or make 2 icons entirely that track different amounts of spell charges. 

 

https://i.imgur.com/eEjwhSc.jpg

 

Here is what I currently use to track it. It'd be more intuitive for players not as familiar with TMW to have a specific condition set out for max charges than to figure out something like I'm doing. I'm pretty sure any ability with multiple charges has that listed somewhere on the tooltip, either abilities with inherent multiple charges or those where you can talent to get multiple, so creating a condition where 'max charges' is a true/false logic shouldn't be too hard, I wouldn't imagine?

Posted by CurseForge user Jalopyy | Imported from CurseForge issue #1568 | Raw

[tmw-issue-import]

Honestly, I've kind of wanted this since Mists because of the Monk Momentum talent adding 1 charge to Roll, and I only wanted the icon to show when Roll was recharging, which of course changes based on number of charges.  It was never a big enough deal because I rarely changed that talent row, so I just manually changed stacks required to show each time, but this may become relevant again when I play Paladin in BfA because there's a talent that adds 1 charge to Divine Steed, a very similarly-used ability.

 

Anyway yeah, if it ever became too annoying, I was going to do exactly what you did there.  That's probably why it's not really worth it to do this, but I agree with you it'd be nice for others.

> Posted by CurseForge user Kosouda

[tmw-issue-import]

@Jaloppy - can't you just have the activation condition be "cooldown == 0"? If it's on max charges it's not on cooldown (that's what I am using for SotR for eg)

 

@Kosouda - can't it be achieved with "cooldown > 0 && charges == 0"? 

 

Basically - max charges can be inferred from ability cooldown - if it's not recharging you're at max stacks, and when it's recharging you aren't. So any condition that relies on "max stacks" should also be able to be defined using the spell cooldown condition

 

(I'm also looking into how difficult it is to infer this from LUA API, but I think both use cases can be simply solved without any new options (unless I'm misunderstanding the examples)

 

> Posted by CurseForge user ariehg

[tmw-issue-import]

That wouldn't work because I only want the notification I'm using to trigger when the charges are maxed - if I had 2 charges and 1 remaining, cooldown==0 would proc at both 1 and 2 charges remaining (pretty sure that's how it'd work, because I probably tried that at first).

 

And I know HOW to make it work, that's what the example was for. The suggestion is for people less capable with TMW to have an easy option because they don't know enough to string multiple conditions together.

> Posted by CurseForge user Jalopyy

[ascott18]

cc @Jalopyy

[ascott18]

@Jalopyy what was the goal here - does a condition for "Is Recharging" solve what you wanted?

[Jalopyy]

I'm trying to remember why exactly I asked for this since it's been a long time + I don't currently play (BFA bleh), but yea, that would work if you can also inverse it to 'Is Not Recharge' so it could succeed when attached to a spell cooldown tracker that has more than one use.

[Kosouda]

Wow, this was a long time ago, but I got an email notification so here I am. Looking back, it does seem like my issue with Roll charges could have easily been solved with just cooldown > 0, yeah. But I have a feeling I tried that and it didn't work because recharging charges was apparently different than a normal cooldown, like it only worked if it had no more charges left. ...I think. I can't confidently remember for sure.

In any case, even though BfA looked good to me back then and still does, I decided to stick with FFXIV instead after all. Even though I don't care for myself anymore, it still seems reasonable to me that this condition could be helpful for some people.

[no-response[bot]]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

[ascott18]

bad @no-response bot, bad! (it doesn't understand that @tmw-issue-import isn't really the original author of this)

Thanks for the responses, guys.