search

ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
84 stars 11 forks source link

[Shadowlands] [Bug] Crash when trying to edit text icons' displays #1806

Closed dygyijingbeizhanyong closed 3 years ago

dygyijingbeizhanyong commented 4 years ago

What version of TellMeWhen are you using?

9.0 PTR

What steps will reproduce the problem? 1.When the mouse moves to the box under the text display scheme, the game will exit directly 2. 3.

What do you expect to happen? What happens instead?

Screenshots and Export Strings

Additional Info

ascott18 commented 4 years ago

In the future, please include relevant screenshots and messages of the errors that you encounter when reporting a bug.

ascott18 commented 4 years ago

This bug is on Blizzard's end - there's nothing I can do about it short of gutting functionality out of TMW.

image

arieh commented 4 years ago

I am also seeing this on Mac OSX. This seems to be triggred by the dogtags help menu, since it only happens after dogtags are loaded, and for eg, if I remove my local fix to DogTags backdrop it's no longer an issue. I'll try and dive a bit deeper into it - it's possible temporarily disabling some functionality might be the best action here until blizz fix it

arieh commented 4 years ago

Ok - further investigation - basically, the single line that crashes WoW is helpFrame:Show() at the end of Help.lua

Some interesting things I've noticed while debugging this: The game has no issues actually rendering the helpFrame - I went about this by returning early, and if you return as late as line 1217 (so - just the definition of the Show method), the entire UI of the help menu renders fine without crashing at all (another interesting tidbit - this is actually a piece of UI I've never seen before? is this new?)

I'll be happy to help investigate this further but this is about as far as I can get without knowing more details about what the Show function actually does and what might cause it to crash.

So, steps taken to get TMW into a functioning version:

  1. Add BackdropTemplate to helpFrame, treeFrame and mainFrame in LibDogTag/Help.lua
  2. Comment out line 1217 in LibDog/Help.lua

Although this clearly disables functionality, I could not figure out what that functionality is

ascott18 commented 4 years ago

I'm not going to go bisecting through DogTag to try and track down a Blizzard bug. Furthermore, if I do add some kind of workaround or just straight up removal of functionality to work around this, it significantly reduces the number of people reporting this crash to Blizzard and therefore significantly reduces the chances they will fix it.

If you're still getting Backdrop issues on the help frame, you're using an old version of LibDogTag.

The help frame has existed essentially as long as DogTag has existed, and has always been available via /dt or by clicking the "?" in the top-right corner of the suggestion list when the suggestion list is listing out tags.

ascott18 commented 3 years ago

They fixed this at some point.