ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
80 stars 11 forks source link

[Bug] Lua errors with Retail 9.0.5 #1868

Closed zjx2172 closed 3 years ago

zjx2172 commented 3 years ago

I'm getting Lua errors after the patch:

SetMinMaxValues(min,max) max must be finite

TellMeWhen version 9.0.4 WoW version 0.0.5 (37862)

Error text from BugSack:

36x ...aceTellMeWhen\Options\TellMeWhen_Options.lua:2708: <unnamed>:SetMinMaxValues(min, max) max must be finite
[string "=[C]"]: in function 'SetMinMaxValues_base'
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:2708: in function 'UpdateRange'
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:2368: in function 'SetValue'
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:2742: in function <...aceTellMeWhen\Options\TellMeWhen_Options.lua:2734>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
[string "=(tail call)"]: ?
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:1129: in function 'CScriptCall'
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:995: in function <...aceTellMeWhen\Options\TellMeWhen_Options.lua:987>
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:1000: in function <...aceTellMeWhen\Options\TellMeWhen_Options.lua:987>
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:1000: in function <...aceTellMeWhen\Options\TellMeWhen_Options.lua:987>
...
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:1129: in function 'CScriptCall'
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:980: in function <...aceTellMeWhen\Options\TellMeWhen_Options.lua:968>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:1040: in function 'CScriptBubble'
[string "@TellMeWhen\Options\TellMeWhen_Options.lua"]:1469: in function 'OnSettingSaved'
[string "@TellMeWhen\Components\Core\Conditions\Config.lua"]:752: in function 'SelectType'
[string "@TellMeWhen\Components\Core\Conditions\Config.lua"]:197: in function 'func'
[string "@TellMeWhen\Options\TMWUIDropDownMenu.lua"]:473: in function 'Button_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
fault-tt commented 3 years ago

I'm getting the same thing. just echoing and hoping this gets fixed really soon. :( . Just a note that even do a cache/wtf clear does nothing so don't waste 3 hours trying to troubleshoot this like I did. :(

zanth77 commented 3 years ago

I opened the TMW addon in notepad++ and replaced math.huge with 1e15 to work around the issue. I do NOT recommend anyone else try this since I did NOT study the code. I like to live dangerously, and it gets rid of the lua errors for me. (note, I did backup my wtf folder just in case)

fault-tt commented 3 years ago

which file/s and line/s exactly? if you don't mind/have the time. I've realised I can't configure values for conditionals while ignoring the lua errors with bugsack and I need this to work for my everyday gameplay :(. I too am willing to live dangerously to get this to work. I've opened tellmewhen.lua and did a search for math.huge and it's not returning any results

zanth77 commented 3 years ago

I ransacked then notepad edited them all at once. So...lots. :slight_smile: Here was my end result. Again I do NOT recommend using my version of this addon as it likely will make your computer melt. :slight_smile: https://drive.google.com/file/d/1Uu2PKPcJbLl4mjI_Mfr-ixFjUrJvuq9U/view?usp=sharing

fault-tt commented 3 years ago

Thanks, you are both a gentleman and a scholar. Worked like a charm.

ascott18 commented 3 years ago

Thanks B̷̡̜̠͆̅l̶̖̫͐́i̴̮͈̥̣̪̓́̌͘̚z̷̨̙͇͎̈͜z̵̨̧͚̣̈̇a̷̤̻̮̩̞̽́r̸͔̻̰̠͋̽ď̷̟̼̞͍̊, very cool change.