ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
80 stars 11 forks source link

[Bug] DogTag [Combos] sometimes incorrectly returns 0 after the target dies #1907

Closed kvigue closed 2 years ago

kvigue commented 3 years ago

What version of TellMeWhen are you using? v9.1.0

What steps will reproduce the problem?

  1. Playing a Subtlety Rogue specced into Deeper Stratagem.
  2. Find a mob in the world. Kill it with Backstab spam, so that you're generating Combo Points. While the mob is alive, the counter will display your Combo Points correctly.
  3. When the mob dies, there is a chance that the icon will begin displaying "0", even if you have non-zero Combo Points. Changing your target (e.g. targeting the mob's corpse) will sometimes fix this, and the number may even "flicker" to 0 before returning to the true value.
  4. Note: the conditions and notifications on the icon are working correctly, so I think that the Combo Point condition check is working fine. This is purely an issue with the DogTag.

What do you expect to happen? What happens instead? The icon should continue displaying the true Combo Points of the Rogue, even after the target dies. The text should not display 0 incorrectly.

Note that gaining or losing combo points will correct the issue. While leveling my Rogue, this has mostly been a problem for figuring out how many Combo Points I have after killing a mob. Once I actually start attacking the next mob, the counter will be accurate again.

Screenshots and Export Strings

^1^T^SType^Sconditionicon ^SEvents^T ^N1^T ^SFade^b ^SType^SAnimations ^SAlpha^N1 ^SImage^S253754 ^SPeriod^N0 ^SAnimation^SICONOVERLAYIMG ^SEvent^SWCSP ^SOnConditionConditions^T ^N1^T ^SType^SCOMBO ^SLevel^N6 ^t^N2^T ^SType^SCOMBO ^SLevel^N5 ^SPrtsBefore^N1 ^SAndOr^SOR ^t^N3^T ^SType^STALENTLEARNED ^SPrtsAfter^N1 ^SLevel^N1 ^SName^SDeeper~`Stratagem ^t^Sn^N3 ^t^t^Sn^N1 ^t^SSettingsPerView^T ^Sicon^T ^STextLayout^STMW:textlayout:1QXGQf8gNVPY ^STexts^T ^N1^S[Combos] ^N2^S[Stacks:Hide(0)] ^t^t^t^SCustomTex^S205234 ^SStates^T ^N1^T ^SAlpha^N0.8 ^t^t^SEnabled^B ^SConditions^T ^N1^T ^SType^SCOMBO ^SOperator^S> ^t^N2^T ^SType^SCOMBAT ^SAndOr^SOR ^t^Sn^N2 ^t^t^N91000^S~`~| ^Sicon^^

^1 ^T^N1^T ^SAnchors^T ^N1^T ^Sy^N-1 ^Sx^N1 ^t^t^SStringName^SNumber ^SName^SArial~`Black ^SConstrainWidth^b ^SSize^N16 ^t^SGUID^STMW:textlayout:1QXGQf8gNVPY ^SName^SCenter~`Number~`2 ^t^N91000^S~`~| ^Stextlayout^STMW:textlayout:1QXGQf8gNVPY ^^

^1 ^T^N1^T ^SAnchors^T ^N1^T ^Sy^N-1 ^Sx^N1 ^t^t^SStringName^SNumber ^SName^SArial~`Black ^SConstrainWidth^b ^SSize^N16 ^t^SGUID^STMW:textlayout:1QXGQf8gNVPY ^SName^SCenter~`Number~`2 ^t^N91000^S~`~| ^Stextlayout^STMW:textlayout:1QXGQf8gNVPY ^^

Example screenshot: The icon is using the yellow texture, indicating that the condition of "Rogue has 6 Combo Points" is passing. However, the [Combos] DogTag returns 0. image

Additional Info

Thank you for making this great addon! :D