search

ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
86 stars 11 forks source link

GetItemCooldown Errors in Wrath PTR #2046

Closed ornumladnar closed 1 year ago

ornumladnar commented 1 year ago

WoW Version

Wrath Classic

TellMeWhen Version

10.0.0.6 r1

Describe the bug

Unable to import full profile from Wrath Classic into Wrath Classic PTR

When manually recreating my profile, any icons used for tracking item CD's spew out many errors Grenades/Sappers/Potions/Gloves/boots/cloak/trinkets

177x ...ceTellMeWhen/Components/Core/Common/Item.lua:278: attempt to call upvalue 'GetItemCooldown' (a nil value) [string "@TellMeWhen/Components/Core/Common/Item.lua"]:278: in function GetCooldown' [string "@TellMeWhen/Components/IconTypes/IconType_item/item.lua"]:130: in functionUpdateFunction' [string "@TellMeWhen/Components/Core/Icon.lua"]:784: in function `Update' [string "@TellMeWhen/Components/IconTypes/IconType_item/item.lua"]:234: in function <...llMeWhen/Components/IconTypes/IconType_item/item.lua:216>

[string "@TellMeWhen/Components/Core/Icon.lua"]:1038: in function `Setup' [string "@TellMeWhen/Options/IconConfig.lua"]:71: in function <TellMeWhen/Options/IconConfig.lua:65>

... [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:994: in function <...aceTellMeWhen/Options/TellMeWhen_Options.lua:981> [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:994: in function <...aceTellMeWhen/Options/TellMeWhen_Options.lua:981> [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:994: in function <...aceTellMeWhen/Options/TellMeWhen_Options.lua:981> [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:994: in function <...aceTellMeWhen/Options/TellMeWhen_Options.lua:981> [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:994: in function <...aceTellMeWhen/Options/TellMeWhen_Options.lua:981> [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:1023: in function CScriptTunnel' [string "@TellMeWhen/Options/TellMeWhen_Options.lua"]:822: in functionSaveSettings' [string "@TellMeWhen/Components/Core/Common/IconDragger.lua"]:397: in function func' [string "@TellMeWhen/Options/TMWUIDropDownMenu.lua"]:473: in functionButton_OnClick'

Export Strings

N/A
ascott18 commented 1 year ago

I can't believe they're actually just going to remove GetItemCooldown. Its not gone in retail, so it makes no sense to be gone in Wrath. WeakAuaras is also just treating this is as a blizz bug. https://github.com/WeakAuras/WeakAuras2/commit/6cff09ddca3402d3d69b0810487fda45fa569a9a

ascott18 commented 1 year ago

Looks like its back as C_Container.GetItemCooldown

ssateneth commented 1 year ago

just to add, i changed line 21 of tellmewhen\components\core\common\item.lua from

= IsEquippedItem, GetItemCount, GetItemInfo, GetItemCooldown, GetItemIcon, IsItemInRange

to

= IsEquippedItem, GetItemCount, GetItemInfo, C_Container.GetItemCooldown, GetItemIcon, IsItemInRange

and the error went away