ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
80 stars 11 forks source link

Timers break when going into DotI #2125

Open arieh opened 7 months ago

arieh commented 7 months ago

WoW Version

Retail

TellMeWhen Version

10.2.0

Describe the bug

This is a very weird bug, and as far as I can tell, only happens when I enter DotI: When I go into the instance, my timers stop working, and am getting this error:

2x [string "safecall Dispatcher[1]"]:9: script ran too long
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
[string "=(tail call)"]: ?
[string "@TellMeWhen/TellMeWhen.lua"]:2728: in function `UpdateNormally'
[string "@TellMeWhen/TellMeWhen.lua"]:2877: in function `Update'
[string "@TellMeWhen/TellMeWhen.lua"]:2885: in function `?'
[string "@ElvUI_Libraries/Core/Ace3/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <...UI_Libraries/Core/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
func = <function> defined @TellMeWhen/Components/Core/Group.lua:425
(*temporary) = true
(*temporary) = "script ran too long"
method = <function> defined @TellMeWhen/Components/Core/Icon.lua:937
arg1 = TellMeWhen_Group12_Icon24 {
 0 = <userdata>
 group = TellMeWhen_Group12 {
 }
 ComponentsLookup = <table> {
 }
 Update_Method = "auto"
 EventHandlersSet = <table> {
 }
 attributes = <table> {
 }
 ID = 24
 GUID = ""
 Enabled = false
 Type = ""
 NextUpdateTime = 0
 TempGUID = "TMW:icon:1bPQLk2qkyO4"
 Modules = <table> {
 }
 Components = <table> {
 }
 SettingsPerView = <table> {
 }
 Name = ""
 lmbButtonData = <table> {
 }
 typeData = <table> {
 }
 Events = <table> {
 }
 position = <table> {
 }
 viewData = <table> {
 }
 Conditions = <table> {
 }
 UnitConditions = <table> {
 }
 States = <table> {
 }
}
xpcall = <function> defined =[C]:-1
call = <function> defined safecall Dispatcher[1]:3
eh = <function> defined @TellMeWhen/TellMeWhen.lua:508

I'm adding an export string of a broken icon, but I'm not conviced it's an issue with a specific icon. reloading TMW or the game solves the issue (this only happens when the buff is up I think - the icon I exported tracks Howling Rune on my weapon)

Export Strings

^1^T^SType^Swpnenchant ^SGUID^STMW:icon:1ZcTfE2QQJCL ^SEnabled^B ^SSettingsPerView^T ^Sicon^T ^STextLayout^STMW:textlayout:1R_vWbTCnJUc ^STexts^T ^N1^S[(Duration~`/~`60):Round:TMWFormatDuration] ^t^t^t^SCustomTex^S48846 ^t^N102000^S~`~| ^Sicon^^

^1 ^T^N1^T ^SAnchors^T ^N1^T ^Spoint^SBOTTOM ^SrelativePoint^STOP ^t^t^SStringName^STop~`Text ^SSize^N7 ^t^SGUID^STMW:textlayout:1R_vWbTCnJUc ^SName^STop~`Time ^t^N102000^S~`~| ^Stextlayout^STMW:textlayout:1R_vWbTCnJUc ^^
arieh commented 7 months ago

I can see it has something to do with ElvUI, but unsure what the interaction is

ascott18 commented 7 months ago

Elvui is just the addon that happened to have loaded AceTimer first, since "E" comes before "T".