ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
80 stars 11 forks source link

Slice and Dice duration incorrect #2144

Open LeCampy opened 5 months ago

LeCampy commented 5 months ago

WoW Version

Retail

TellMeWhen Version

10.2.2

Describe the bug

Tracking Buff/Debuff Slice and Dice (either id 315496 or 344362) with Show Timer and Show Timer text, targetting player will set the duration to 2h when the initial start timer is over 60 seconds, and will not countdown properly; sometimes it counts down once it goes below 50 seconds, sometimes it stays at 2h for the full duration until the buff falls off

WoWScrnShot_011524_110307

Export Strings

^1^T^SShowTimer^B ^SType^Sbuff ^SShowTimerText^B ^SName^SSlice~`and~`Dice ^SEnabled^B ^t^N102201^S~`~| ^Sicon^^
Alwies commented 5 months ago

Had a chat with someone about this on discord a while back. The talent "Underhanded Upper Hand" Image will freeze the duration during blade flurry, the actual implementation in the API however is just multiple the remaining time by 100. Which is why it displays 2 hours.

Now where there may be a bug is that it should revert to normal duration outside of flurry and shouldn't fall off unless the timer hits 0. Assuming there's no rogue mechanic that removes it. Now what can happen if you "freeze" it with a few seconds remaining it'll go to a big number again but when unfrozen disappear very fast.

LeCampy commented 5 months ago

Should have known it was the redesign, the timing lines up.

And I have to amend my previous account, there's no bug then, it's reverting back to normal countdown when BF falls off.

The problem is that BF should not fall off at least in dungeons, so I wasn't seeing the pattern. If the display issue with Underhanded Upper Hand is a "Broken as Designed", because of Blizz code, I def can live with that.