ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
80 stars 11 forks source link

Item use opacity is now wrong #2155

Closed AzatoR62 closed 3 months ago

AzatoR62 commented 3 months ago

WoW Version

Retail

TellMeWhen Version

10.2.3

Describe the bug

I had 2 icons, one for Fyr'alath and the other for ashes (trinket). I set opacity at 100 when usable and 30 when unusable. Before all worked fine, but since today my icon will always be on 'Unusable' at 30 opacity, even if both my items are usable. Strangely when i set the opacity of 'Unusable' at 100, it change the opacity of my icons. Even if they are usable, it's the opacity of unusable that is used. Have an idea ? :)

Export Strings

N/A
Alwies commented 3 months ago

To add as for me there's slight differences.

Equipped trinkets work as expected for me. However items like healing potions use the "Unusable" opacity/color settings when they're in fact usable. EG: healing potion icon:

^1^T^SShowTimer^B ^SType^Sitem ^SName^SDreamwalker's~`Healing~`Potion ^SShowTimerText^B ^SStates^T ^N2^T ^SColor^Sffffffffd ^SAlpha^N1 ^t^t^SEnabled^B ^t^N102301^S~`~| ^Sicon^^

ascott18 commented 3 months ago

Blizzard changed GetItemCooldown to return booleans in its third return, but didn't change the inventory version of the function to do the same. Awesome.

image

AzatoR62 commented 3 months ago

Everything is great again ! Thanks for the reactivity and the good work, keep it rollin' :)