ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
83 stars 11 forks source link

LUA Error in PlayerAttributes using "Tracking active" condition #2179

Closed canofbutter closed 1 month ago

canofbutter commented 1 month ago

WoW Version

Retail

TellMeWhen Version

11.0.1

Describe the bug

"Tracking active" for any profession (including find fish) generates this error on most character (but strangely not all?)

Message: ...ents/Core/Conditions/Categories/PlayerAttributes.lua:341: bad argument #1 to 'strlower' (string expected, got table)
Time: Wed Jul 24 22:43:31 2024
Count: 3
Stack: ...ents/Core/Conditions/Categories/PlayerAttributes.lua:341: bad argument #1 to 'strlower' (string expected, got table)
[string "@Interface/AddOns/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:109: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>
[string "=[C]"]: ?
[string "@Interface/AddOns/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Interface/AddOns/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Interface/AddOns/Ace3/AceDB-3.0/AceDB-3.0.lua"]:462: in function `SetProfile'
[string "*MainConfig.xml:320_OnLoad"]:16: in function `func'
[string "@Interface/AddOns/TellMeWhen/Options/TMWUIDropDownMenu.lua"]:473: in function `Button_OnClick'
[string "*TMWUIDropDownMenuTemplates.xml:83_OnClick"]:1: in function <[string "*TMWUIDropDownMenuTemplates.xml:83_OnClick"]:1>

Locals: self = TMW {
 CovenantIcons = <table> {
 }
 modules = <table> {
 }
 DS = <table> {
 }
 db = <table> {
 }
 ALLOW_LOCKDOWN_CONFIG = true
 operators = <table> {
 }
 isNumber = <table> {
 }
 COMMON = <table> {
 }
 TEXT = <table> {
 }
 EquivFullIDLookup = <table> {
 }
 InitializedDatabase = true
 name = "TellMeWhen"
 Defaults = <table> {
 }
 C = <table> {
 }
 BackupDate = "10:30:47 PM"
 SNIPPETS = <table> {
 }
 OrderedTypes = <table> {
 }
 justifyVPoints = <table> {
 }
 Views = <table> {
 }
 defaultModuleState = true
 CHANGELOG_LASTVER = "7.4.0"
 HELP = <table> {
 }
 UPD_INTV = 0.021000
 Locked = true
 NAMES = <table> {
 }
 GUIDToOwner = <table> {
 }
 InCombat = false
 justifyPoints = <table> {
 }
 GCD = 0
 EventList = <table> {
 }
 EVENTS = <table> {
 }
 EquivOriginalLookup = <table> {
 }
 CONST = <table> {
 }
 indentLib = <table> {
 }
 GroupsToUpdate = <table> {
 }
 GCDSpell = 53
 Classes = <table> {
 }
 isRetail = true
 Group_Defaults = <table> {
 }
 SpellTexturesMetaIndex = <table> {
 }
 Warned = true
 performedEvent = "TMW_UPGRADE_PERFORMED"
 UNITS = <table> {
 }
 isWrath = false
 profile = <table> {
 }
 DOGTAG = <table> {
 }
 IconStateArbitrator = <table> {
 }
 time = 1165256.084000
 isCata = false
 baseName = "TellMeWhen"
 TIMERS = <table> {
 }
 startgold = 587909322
 Backupdb = <table> {
 }
 Icon_Defaults = <table> {
 }
 strlowerCache = <table> {
 }
 SUG = <table> {
 }
 DD = <table> {
 }
 DROPDOWNMENU = <table> {
 }
 BE = <table> {
 }
 enabledState = true
 Initialized = true
 points = <table> {
 }
 IE = TellMeWhen_IconEditor {
 }
 CI = <table> {
 }
 isClassic = false
 EquivFirstIDLookup = <table> {
 }
 EquivFullNameLookup = <table> {
 }
 CNDT = <table> {
 }
 DEFAULT_ICON_SETTINGS = <table> {
 }
 defaultModuleLibraries = <table> {
 }
 IconEventUpdateEngine = Frame {
 }
 PreviousGUIDToOwner = <table> {
 }
 COUNTERS = <table> {
 }
 IconsToUpdate = <table> {
 }
 L = <table> {
 }
 ValidityCheckQueue = <table> {
 }
 orderedModules = <table> {
 }
 IconDragger = <table> {
 }
 OrderedViews = <table> {
 }
 CompareFuncs = <table> {
 }
 Types = <table> {
 }
 HaveUpgradedOnce = true
 global = <table> {
 }
 callbackregistry = <table> {
 }
}
method = "OnProfile"

Export Strings

^1^T^SType^Sconditionicon ^SConditions^T ^N1^T ^SType^STRACKING ^SName^SFind~`Herbs ^t^Sn^N1 ^t^SGUID^STMW:icon:1bkIbgG=Opm5 ^SFakeHidden^B ^SCustomTex^S2383 ^SEnabled^B ^t^N110101^S~`~| ^Sicon^^
canofbutter commented 1 month ago

Digging into this a little more, it looks like the recently moved GetTrackingInfo to C_Minimap.GetTrackingInfo returns a table structure rather than using multiple ordered return values. The "name" and "active" members of this structure behave the same as the prior separate return values.