ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
86 stars 11 forks source link

Pet abilities don't auto disappear\change without a /reload #2240

Open sethiano opened 1 month ago

sethiano commented 1 month ago

WoW Version

Retail

TellMeWhen Version

11.0.10

Describe the bug

Hi!

First off, thank you for such an amazing addon!!! I appreciate your time and abilities.

I noticed pet abilities don't disappear\change without an update.

For example, if I am using a pet with Master's Call, and make a Master's call; primal rage spell cooldown icon, it will work great to show the cd for master's call, but if I dismiss my pet, and summon a pet with primal rage, the icon will stay showing master's call, even though it's not an active move.

If I do something similar with a player ability, let's say, mending bandage\sticky tar bomb, and swap the talents back and forth, tmw will auto change the icon.

Please me know if you need more detail.

TYTYTYTY!

Export Strings

^1^T^SStrata^SBACKGROUND ^SPoint^T ^Sy^F5741069362790399 ^f-45^Sx ^F-4604021689374037^f-54 ^Spoint^SBOTTOM ^SrelativePoint^SBOTTOM ^t^SScale^N1.5 ^SRows^N2 ^SRole^N5 ^SEnabledSpecs^T ^N581^b ^N270^b ^N268^b ^t^SGUID^STMW:group:1Q_dJHlzFIKh ^SColumns^N11 ^SIcons^T ^N1^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Sgrowl ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N2^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Sflare ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N3^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Smend~`pet ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N4^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SExhilaration ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N5^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SRoar~`of~`Sacrifice ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N6^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SSurvival~`of~`the~`Fittest ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N7^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SAspect~`of~`the~`Turtle ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N8^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SAspect~`of~`the~`Cheetah ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N9^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Smaster's~`call;~`Primal~`Rage;~`Fortitude~`of~`the~`Bear ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N10^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SSpatial~`Rift ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N11^T ^SShowTimer^B ^SType^Sitem ^SShowTimerText^B ^SName^S218716 ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N12^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^STranquilizing~`Shot ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N13^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Star~`trap ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N14^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Shigh~`Explosive~`Trap;~`Implosive~`Trap ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N15^T ^SShowTimer^B ^SOnlyEquipped^B ^SType^Scooldown ^SOnlyInBags^B ^SName^Sfreezing~`trap ^SShowTimerText^B ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N16^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SChimaeral~`Sting;~`Sticky~`Tar~`Bomb;~`Misdirection ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N17^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Sscatter~`shot;~`bursting~`shot ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N18^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Sbinding~`shot ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N19^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SIntimidation ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N20^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SBestial~`Wrath;~`trueshot;~`Coordinated~`Assault ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N21^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^Strueshot;~`bloodshed;~`spearhead ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N22^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SName^SDire~`Beast:~`Basilisk ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^SEnabled^B ^t^N23^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^t^N24^T ^SShowTimer^B ^SType^Scooldown ^SShowTimerText^B ^SStates^T ^N2^T ^SAlpha^N1 ^t^t^t^t^SName^SHPVP~`Cooldowns ^SSettingsPerView^T ^Sicon^T ^SSpacingY^N1 ^SSpacingX^N1 ^t^t^t^N11001001^S~`~| ^Sgroup^N8 ^^
Alwies commented 1 month ago

That's because the game considers a pet spell learned if that pet has been out after the last loading screen, regardless of it having been dismissed since. With talents the game correctly realizes the spell is no longer "learned" when untalented. TMW is reporting based on what the game tells it.

Easiest way around this is to track the base ability "Command Pet" instead of one of the three abilities it can change into. If that doesn't work for your situation and you want 3 separate icons than use the condition "Pet specialization" to make an icon hide if that specialization is not currently out. If either of these suggestions give you issues, feel free to come to the TMW discord.

sethiano commented 1 month ago

Oh, awesome! Thank you for the clarification. I’m glad it’s not a bug and it’s something I can try to work on. I’m sure your solutions will work. Thank you so much For taking the time to explain that to me and even offer some solutions.

I hope you have a wonderful weekend! Thank you again for making such a great add-on.

[This email was sent from my iPhone. Please excuse any grammatical or punctuation errors.]

-Seth Cowell-

On Fri, Oct 18, 2024 at 1:40 PM Alwies @.***> wrote:

That's because the game considers a pet spell learned if that pet has been out after the last loading screen, regardless of it having been dismissed since. With talents the game correctly realizes the spell is no longer "learned" when untalented. TMW is reporting based on what the game tells it.

Easiest way around this is to track the base ability "Command Pet" instead of one of the three abilities it can change into. If that doesn't work for your situation and you want 3 separate icons than use the condition "Pet specialization" to make an icon hide if that specialization is not currently out. If either of these suggestions give you issues, feel free to come to the TMW discord.

— Reply to this email directly, view it on GitHub https://github.com/ascott18/TellMeWhen/issues/2240#issuecomment-2423200579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGOKPSJ6IQFFLR25BYR33O3Z4FW4LAVCNFSM6AAAAABQGNENO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGIYDANJXHE . You are receiving this because you authored the thread.Message ID: @.***>

sethiano commented 1 month ago

Command Pet tracking works perfect. tyvm!