ascott18 / TellMeWhen

TellMeWhen is a combat tracking AddOn for World of Warcraft Retail and Classic
https://wow.curseforge.com/projects/tellmewhen
GNU General Public License v3.0
86 stars 11 forks source link

[CF 565] 'script ran too long' #587

Closed tmw-issue-import closed 12 years ago

tmw-issue-import commented 12 years ago

What steps will reproduce the problem?
1. Had this come up while killing Van in AV- export below

What version of TellMeWhen are you using? ("The latest" is not a version)
6.0.2

Do you have an error log of what happened?
Message: ..\AddOns\TellMeWhen\TellMeWhen.lua line 3287: script ran too long
full report: http://pastebin.com/T8scca5x

and

Message: [string "safecall Dispatcher[4]"] line 9: script ran too long
full report: http://pastebin.com/ciYUVxut

Please provide any additional information below (including any export strings if applicable; see above.)
full export: http://pastebin.com/5xQK89rX

Stuff going on at the time:
[ ~20 people in Van's room ]
[10:51:28] [Brotems][Bloodlust]
[10:51:28] [B] [85:Totemnotto-Kil]: all in!!!!
[10:51:29] Swatter caught error: [Global]
[10:51:29] Swatter caught error: [Global]
[10:51:29] [Prïest][Power Word: Barrier]
[10:51:29] Wing Commander Mulverick yells: I come for you, puny Alliance!

Hope this is helpful! Thanks again for your work on this incredible addon.


Posted by CurseForge user kaustos | Imported from CurseForge issue #565 | Raw

tmw-issue-import commented 12 years ago

This makes me cry. Not only because I'm forced to comply with Blizzard's completely arbitrary execution cap, but also because this error isn't happening during config or anything. Its happening during normal usage.

However, I have no idea why it is happening. Using your profile, even if I completely disable the update interval and all event based updating, it doesn't even get near Blizzard's execution cap.

Now, the second error is the most interesting because I can actually see what was going on when it happened. Group 5's condition just started passing, and so the group was shown. The error occurred when trying to show the group. I can't imagine why simply showing a group would cause such a great deal of CPU strain.

I supposed the only way I might understand this is if I ask,

What CPU and graphics card do you have in your computer?


> Posted by CurseForge user Cybeloras
tmw-issue-import commented 12 years ago

I play on a laptop and it does struggle a bit in heavy raids but it's not quite a dinosaur. Dell Studio 1535- Core 2 Duo @ 2ghz, ATI Radeon HD 3400, 3gb ram.

I got a similar 'script ran too long' error tonight with DBM while in LFR, the moment we engaged Ultraxion. No idea if it's related, Blizzards fault, DBM bug, other random broken addons or just an issue of an older system. http://pastebin.com/0G2g3Fb0 http://pastebin.com/cntMu6Ym

Anything I can do to help debug?


> Posted by CurseForge user kaustos
tmw-issue-import commented 12 years ago

Well, the first error is happening during a :Show() (same as the first error with TMW), which suggests to me that there may be another addon hooking the :Show() method and causing it to slow down. Or, it may be some issue related to your hardware, but I don't think that this would be the case.

The second DBM error is probably just a side-effect of the first error. Not worried about that one.

Although, after doing some research just now, you aren't the only one getting this:

http://www.curse.com/addons/wow/deadly-boss-mods (see the comments, especially page 2)

The best way you can help, or at least all I can think of right now, is just to keep posting these errors (even for other addons). Especially if you can find a circumstance where you can reliably reproduce the issue.


> Posted by CurseForge user Cybeloras
tmw-issue-import commented 12 years ago

Got the same error tonight. This time I was alone soloing Onyxia and I have 60 vsync'd fps in her lair. The error occurred 2 seconds after starting combat, though I'm not sure if I had her targeted already or if the error was at the moment I targeted her. But, it's triggering only when I target a raid boss (Van before) and isn't system performance related, something somehow borked with that icon group. I was in a utterly massive 40+v40+ pvp brawl in Durotar and Elwynn Forest today (holy shit@crossrealm zones), where I was getting literally 4 fps already from the damn uber leafy trees and didn't receive any errors at all.

It's also only happening on my druids profile. Cleared Firelands and Solo'd Onyxia on my rogue just prior and didn't get any such errors, despite using a lot of the exact same groups. I've included an export of my rogues profile as well. edit: Well, I take that back partially. Got the same error on my rogue when I got jumped by a level 90 guard.

error1: http://pastebin.com/kw0ncMRU error2: http://pastebin.com/nM6Dt2Jc updated export from druid: http://pastebin.com/ve83nnu2 rogue profile export:http://pastebin.com/LziNUgwB


Edited Sep 5, 2012

> Posted by CurseForge user kaustos
tmw-issue-import commented 12 years ago

Had a similar error pop while setting up against the Training Dummy apologies, not sure why it truncated the error

1x TellMeWhen-r597\Lib\21LibDogTag-3.0-90203\Parser.lua:1784: script ran too long TellMeWhen-r597\Lib\21LibDogTag-3.0-90203\Parser.lua:1784: in function "ColorizeCode" Components\IconModules\IconModule_Texts\Config.lua:1230: in function "Entry_AddToList" TellMeWhen-r597\Components\Core\Suggester\Suggester.lua:192: in function "SuggestingComplete" TellMeWhen-r597\Components\Core\Suggester\Suggester.lua:116: in function "DoSuggest" TellMeWhen-r597\Components\Core\Suggester\Suggester.lua:300: in function "NameOnCursor" TellMeWhen-r597\Components\Core\Suggester\Suggester.lua:327: in function <TellMeWhen\Components\Core\Suggester\Suggester.lua:314> <in C code>

Locals: self = <table> { showColorHelp = false noTexture = true NewModule = <func> @AdiBags\libs\..\AceAddon-3.0.lua:256 EnableModule = <func> @AdiBags\libs\..\AceAddon-3.0.lua:348 modules = <table> {} GetModule = <func> @AdiBags\libs\..\AceAddon-3.0.lua:231 IterateEmbeds = <func> @AdiBags\libs\..\AceAddon-3.0.lua:458 defaultModuleLibraries = <table> {} Sorter = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1283 helpText = "The following are tags that you may wish to use in this text display. Using a substitution will cause it to be replaced with the appropriate data wherever it is displayed.

For more information about these tags, and for more tags, click this button.

Clicking on an entry will insert it into the editbox." GetName = <func> @AdiBags\libs\..\AceAddon-3.0.lua:300 name = "TellMeWhen_Suggester_dogtags" IsEnabled = <func> @AdiBags\libs\..\AceAddon-3.0.lua:467 orderedModules = <table> {} DisableModule = <func> @AdiBags\libs\..\AceAddon-3.0.lua:366 helpOnClick = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1142 OnSuggest = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1151 headerText = "DogTags:" IsModule = <func> @AdiBags\libs\..\AceAddon-3.0.lua:238 SetDefaultModuleState = <func> @AdiBags\libs\..\AceAddon-3.0.lua:403 InvalidEntries = <table> {} SetEnabledState = <func> @AdiBags\libs\..\AceAddon-3.0.lua:440 Table_GetSorter = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1286 enabledState = true baseName = "TellMeWhen_Options" SetDefaultModulePrototype = <func> @AdiBags\libs\..\AceAddon-3.0.lua:425 Entry_Insert = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1179 SetDefaultModuleLibraries = <func> @AdiBags\libs\..\AceAddon-3.0.lua:383 noTab = true Enable = <func> @AdiBags\libs\..\AceAddon-3.0.lua:315 IterateModules = <func> @AdiBags\libs\..\AceAddon-3.0.lua:453 Table_GetNormalSuggestions = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1159 noMin = true Entry_AddToList_1 = <func> @TellMeWhen\Components\IconModules\IconModule_Texts\Config.lua:1228 moduleName = "dogtags" defaultModuleState = true Disable = <func> @AdiBags\libs\..\AceAddon-3.0.lua:330 } f = TellMeWhen_IconEditorSuggestItem15 { 0 = <userdata> Name = TellMeWhen_IconEditorSuggestItem15Name {} ID = TellMeWhen_IconEditorSuggestItem15ID {} Background = TellMeWhen_IconEditorSuggestItem15Background {} Icon = TellMeWhen_IconEditorSuggestItem15Icon {} } tagName = "Stacks:Hide('0')" tag = "[Stacks:Hide('0')]" DogTag = <table> { unparse = <func> @TellMeWhen\Lib\LibDogTag-3.0\Parser.lua:1219 select2 = <func> @TellMeWhen\Lib\LibDogTag-3.0\Helpers.lua:155 callbackToFunction = <table> {} hasEvent = <func> @TellMeWhen\Lib\LibDogTag-3.0\Events.lua:159 IterateFactions = <func> @TellMeWhen\Lib\LibDogTag-Unit-3.0\Categories\Reputation.lua:47 callbackToExtraArg = <table> {} colors = <table> {} Tags = <table> {} CleanCode = <func> @TellMeWhen\Lib\LibDogTag-3.0\Parser.lua:1581 codeToFunction = <table> {} newDict = <func> @Interfac


> Posted by CurseForge user tlon
tmw-issue-import commented 12 years ago

@tlon: Go

This is why I was so hesitant to allow configuration in combat again.

There is no way for me to fix these errors without plunging into TellMeWhen and tearing out half its code.

If they happen while configuring in combat, you will just have to deal with them. If they break something, you might have to reload. If you end up losing settings (highly unlikely), or if I start getting spammed with people reporting these errors, then I will probably disabled config in combat again.


Edited Oct 18, 2012

> Posted by CurseForge user Cybeloras
tmw-issue-import commented 12 years ago

@tlon: Go

This is why I was so hesitant to allow configuration in combat again.

There is no way for me to fix these errors without plunging into TellMeWhen and tearing out half its code.

If they happen while configuring in combat, you will just have to deal with them. If they break something, you might have to reload. If you end up losing settings (highly unlikely), or if I start getting spammed with people reporting these errors, then I will probably disabled config in combat again.

See http://wow.curseforge.com/addons/tellmewhen/tickets/649-help-lua-line-227-bad-argument-1-to-pairs-table-expected/ for the current plan for allowing configuration while in combat.


Edited Oct 18, 2012

> Posted by CurseForge user Cybeloras