search

asd211322 / Net-MVC-Workshop1

0 stars 0 forks source link

[CodeReview]-MVC-View #3

Open GSSBilly opened 5 years ago

GSSBilly commented 5 years ago

MVC Razor Helper

[所有 Dom 物件請使用 Razor Helper 產生]

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/Index.cshtml#L10-L11

GSSBilly commented 5 years ago

冗餘程式碼1

[建議充分利用 Model Binding] DisplayName 可由 View Model 提供，View Model 需補上與搜尋條件相關的成員

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/Index.cshtml#L1

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/Index.cshtml#L15-L38

GSSBilly commented 5 years ago

MVC Razor Helper

[建議都使用強型別 Model Binding 方式]

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/search.cshtml#L14

GSSBilly commented 5 years ago

善用 LINQ

[Any()]

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/search.cshtml#L30

GSSBilly commented 5 years ago

MVC Razor Helper

[EditorFor 有緩存機制應謹慎使用，並留意 Model State的控制]

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/Create.cshtml#L20

GSSBilly commented 5 years ago

未設定為日期控制項

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/Create.cshtml#L37

GSSBilly commented 5 years ago

MVC Razor Helper

[在此不需使用 labelText (客製用途)]

https://github.com/asd211322/Net-MVC-Workshop1/blob/c238943f1a622a680123eaff7052874b0c41548a/ASP_WorkShop_MVC/Views/Home/Create.cshtml#L59