search

asdaraujo / edge2ai-workshop

Edge2AI Workshop
Apache License 2.0
68 stars 102 forks source link

Superfluous parameters should not block execution #28

Open dennisjaheruddin opened 3 years ago

dennisjaheruddin commented 3 years ago

Especially in stack.sh there are some things that block execution if combined.

For example 'you cannot fill in link a and link b at the same time'

This is quite a puzzle for infrequent users. Please let these things generate a warning or confirmation dialog if needed, but simply pick a default one to use when too much is filled in.

asdaraujo commented 3 years ago

Hi, @dennisjaheruddin ,

Could you give me an example of the combination that didn't work for you? I'll take a look at it.

dennisjaheruddin commented 3 years ago

Something like

"You can only fill in the CEM base URL or the CEM repo url"

And there were a few similar ones.

My thought: If we only need one, we should just pick one and perhaps warn about the other being ignored. Now it takes multiple iterations of editing the file and hopefully not throwing away too much/the wrong thing before you get rid of these errors.

Op ma 16 nov. 2020 om 12:25 schreef Andre Araujo notifications@github.com:

Hi, @dennisjaheruddin https://github.com/dennisjaheruddin ,

Could you give me an example of the combination that didn't work for you? I'll take a look at it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/asdaraujo/edge2ai-workshop/issues/28#issuecomment-727918691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3EIFQGRCU2NAR3OPCEPCTSQED25ANCNFSM4TVPTMJA .