search

asdf-community / asdf-direnv

direnv plugin for the asdf version manager
https://github.com/asdf-vm/asdf
Apache License 2.0
559 stars 38 forks source link

Updating my pr #183

Closed X-oss-byte closed 1 year ago

X-oss-byte commented 1 year ago

Choose your PR title well: Your pull request title is what's used to create release notes, and your pull request should add a reference to it on CHANGELOG.md, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.

Overview

What does this change accomplish and why? i.e. How does it change the user experience?

Feel free to include "before and after" examples if appropriate. (You can copy/paste screenshots directly into this editor.)

If relevant, which Github issues does it close? (See closing-issues-using-keywords.)

Implementation notes

How does it accomplish it, in broad strokes? i.e. How does it change the codebase?

Interesting/controversial decisions

Include anything that you thought twice about, debated, chose arbitrarily, etc. What could have been done differently, but wasn't? And why?

Test coverage

Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?

Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?

Loose ends

Link to related issues that address things you didn't get to. Stuff you encountered on the way and decided not to include in this PR.

jfly commented 1 year ago

@sammyfilly, I can't tell what you're trying to accomplish in this PR.

Could you update your commit messages and PR description to explain the purpose of what you're doing here?

smorimoto commented 1 year ago

@jfly As far as I can see from this user's activities elsewhere, they looks like a spam user 😮‍💨