search

asdf-community / asdf-flutter

flutter plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
111 stars 31 forks source link

Versions malformed? #7

Closed mrienstra closed 4 years ago

mrienstra commented 4 years ago

When I run asdf list all flutter, I see:

.17.0-3.2.pre-beta
.17.0-dev.0.0-dev
.17.0-dev.1.0-dev
.17.0-dev.2.0-dev
.17.0-dev.3.0-dev
.17.0-dev.3.1-beta
.17.0-dev.4.0-dev
.17.0-dev.5.0-dev
.18.0-6.0.pre-dev
.18.0-dev.0.0-dev
.18.0-dev.1.0-dev
.18.0-dev.2.0-dev
.18.0-dev.3.0-dev
.18.0-dev.4.0-dev
.18.0-dev.5.0-dev

(truncated, full list: https://gist.github.com/mrienstra/52e68246ecf15ed02e20b137c5a924d4 )

Notably I do not see any of the 1.17.* or 1.18.* versions, instead I see .17.* or .18.*.

Comparing to https://flutter.dev/docs/development/tools/sdk/releases?tab=macos#beta-channel-macos :

1.17.0-3.2.pre
1.17.0-dev.0.0
1.17.0-dev.1.0
1.17.0-dev.2.0
1.17.0-dev.3.0
1.17.0-dev.3.1
1.17.0-dev.4.0
1.17.0-dev.5.0
1.18.0-6.0.pre
1.18.0-dev.0.0
1.18.0-dev.1.0
1.18.0-dev.2.0
1.18.0-dev.3.0
1.18.0-dev.4.0
1.18.0-dev.5.0

Looks like the initial 1 is being stripped off. Presumably because Flutter recently changed their version number format -- used to always start with a v, but they dropped the v as of 1.17.0.

https://github.com/oae/asdf-flutter/blob/master/bin/list-all#L17 has gsub("^v"; "") but that should only strip the first character if it is a v...

oae commented 4 years ago

Last week, I have merged a pull request about this. It should be fixed now if you update the plugin itself. Can you update the plugin and try it again? 

asdf plugin-update flutter
asdf list all flutter
mrienstra commented 4 years ago

Will do! Sorry, I think I forgot to attempt that before opening this issue. 🤦

mrienstra commented 4 years ago

Yup, my bad, I didn't have the latest version. Thanks for the quick response.

Resolved by https://github.com/oae/asdf-flutter/pull/4