search

asdf-community / asdf-hashicorp

HashiCorp plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
240 stars 54 forks source link

test and document support for Boundary and Waypoint + fixes for Consul-related CI failures #16

Closed radditude closed 3 years ago

radditude commented 4 years ago

This PR began as an effort to add tests and documentation for Boundary and Waypoint - both tools are already supported by this plugin with no changes needed, so this is more a formality than anything else.

However, in the process of debugging some failing CI checks, I discovered two problems which needed to be addressed before the CI checks could pass:

  1. Currently, the list-all command does not fully support versions with both a beta and an enterprise suffix. For example, the current latest version of consul is 1.9.0+ent-beta1, but when using list-all, the version number is truncated and rendered as 1.9.0+ent. That version doesn't exist and therefore fails to download.
  2. The asdf plugin-test command attempts to check out the master branch of the repository by default, meaning that tests were being run against the master branch instead of the commit being tested. Luckily, there's a --asdf-plugin-gitref flag which can be passed to the plugin-test command to run the test script against a specific commit.

I've included those two fixes in this PR for now, since the tests don't pass without them, but I'd be happy to break them out into a separate PR if you'd prefer!

Thanks for the great plugin!

Related PRs to the asdf-plugins repo:

Boundary Waypoint

DustinChaloupka commented 3 years ago

Thanks!