search

asdf-community / asdf-poetry

Poetry plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
77 stars 16 forks source link

Use new Poetry installer whenever possible #20

Closed Kurt-von-Laven closed 2 years ago

Kurt-von-Laven commented 2 years ago

Fixes #19.

Previously, the new installer hosted at https://install.python-poetry.org was only used for versions of Poetry that require it, namely 1.2+. The official Poetry documentation recommends immediate migration from the old, deprecated, get-poetry.py installer to the new installer. Hence, use the new installer for all versions of Poetry that support it, namely 1.1.7+.

See this official Poetry blog post announcing the release of 1.2.0 for additional context.

crflynn commented 2 years ago

This looks good. Although I think we should fix #10 first by setting poetry config virtualenvs.prefer-active-python true conditionally on 1.2+, so that asdf+poetry behaves as expected moving forward.

Kurt-von-Laven commented 2 years ago

Thank you for fixing #10! I rebased on your fix.

crflynn commented 2 years ago

Just need to update the tests from 1.2 to 1.1.7

Kurt-von-Laven commented 2 years ago

Whoops; just pushed take two.