search

asdf-community / asdf-poetry

Poetry plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
74 stars 15 forks source link

Update to new Poetry Install Script #9

Closed iwoloschin closed 3 years ago

iwoloschin commented 3 years ago

Fixes #8.

Update the plugin to use the new poetry install script (https://python-poetry.org/blog/announcing-poetry-1.2.0a1/#deprecation-of-the-get-poetrypy-script). The new script is python3 only and no longer attempts to modify $PATH.

I've also unset the PIP_REQUIRE_VIRTUALENV variable during poetry install. The environmental variable shouldn't need to be unset, that is a bug, see https://github.com/python-poetry/poetry/issues/4089 for more details.

cocoonkid commented 3 years ago

Thanks for working on this. Does It work already? 

asdf install poetry latest

Does still try install 1.1.17

iwoloschin commented 3 years ago

I believe that is correct, 1.1.17 is the latest release, 1.2.0a1 is a beta release and probably is not installed unless explicitly requested. Try asdf install poetry 1.2.0a1, that should work fine.

smorimoto commented 3 years ago

Yes, the "latest" selector has an implementation on the asdf side that is intended to avoid rc and beta.

cocoonkid commented 3 years ago

Thank you. That makes complete sense of course. And yes it worked as suggested.