search

asdf-community / asdf-python

Python plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
651 stars 56 forks source link

Pip Auto Reshim Support #136

Closed matan129 closed 2 years ago

matan129 commented 2 years ago

Solves #37. Inspired by the npm version.

johnklehm commented 2 years ago

@danhper @pierreneter

humitos commented 2 years ago

Hi! I came here after reading multiple issues on asdf, the pre/post hooks implemented and the revert of them because of the problem reported with exec.

I'd like to see this feature merged into the asdf-python plugin since it seems that does not modify the core of asdf and only wraps the pip command in a basic way to reshim if it was called with install or uninstall --which sounds to exactly what the user will do manually anyway. Actually, this is what pyenv has been doing as well https://github.com/pyenv/pyenv/blob/master/pyenv.d/exec/pip-rehash/pip#L26

I was wondering if we want to apply the same logic for conda and easy_install as they do (see https://github.com/pyenv/pyenv/tree/master/pyenv.d/exec/pip-rehash). Maybe for other package managers like pipenv, poetry and pdm as well? (I'm not sure about these ones, but worth asking about them 😄 )

matan129 commented 2 years ago

@danhper thoughts?

danhper commented 2 years ago

Hey, sorry for the delay! This looks great, thanks a lot!