search

asdf-community / asdf-python

Python plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
655 stars 56 forks source link

Support / bundling pipenv #26

Closed cLupus closed 6 years ago

cLupus commented 6 years ago

Hi, Is there any plans of integrating pipenv into the plugin?

danhper commented 6 years ago

Hi, I do not have any plans to add pipenv integration, but would gladly accept PRs. Thank you.

omares commented 6 years ago

Hey, i am evaluating if i should switch to asdf and its various plugins and would like to know if pipenv works in conjunction with asdf-python or do the tools conflict with each other?

cLupus commented 6 years ago

My experience is that pipenv works well with asdf. The prgamatic way of installing pipenv, is pip install pipenv, and as long as you ensure that the you are careful with which version of python you use.

Note that Pipenv is set to be the de facto standard, and when the Pipfile format is finalized, it seems likely that pipenv will come with python as standard.

danhper commented 6 years ago

I have now been using pipenv for a little while and it works perfectly with asdf-python, so I will close here. Please comment or open a new issue if you run into issues related to pipenv. Thanks.

ianliu commented 5 years ago

@tuvistavie I've installed pipenv with pip install pipenv, but when I issue pipenv it is not recognized as a command. Any hints why this is happening? Here is some info that might help:

ls ~/.asdf/installs/python/3.7.0/bin/pipenv # OK
ls ~/.asdf/shims/pipenv # File does not exist
ianliu commented 5 years ago

Oh, sorry, I guess I just needed to call asdf reshim python 3.7.0. Thanks

jayvdb commented 5 years ago

An important addition would be detecting Pipfile, read the section which declares the version. This would be a parse-legacy-file hook, and preset for that version to install

[requires]
python_version = "3.6"

That will be much more useful after https://github.com/asdf-vm/asdf/issues/269 , but is still useful atm.

What would be even more useful, but maybe beyond the scope of this plugin (optional feature?), is to automatically activate the pipenv.

and-semakin commented 5 years ago

https://github.com/asdf-vm/asdf/issues/269 is now resolved.