asdf-community / asdf-r

R plugin for the asdf version manager
https://github.com/asdf-vm/asdf
GNU General Public License v2.0
30 stars 6 forks source link

Updates the README to resolve #10 #11

Open signus opened 1 year ago

signus commented 1 year ago

Based on #10 the issue is itself not actually with the install but the instructions provided to install the ASDF plugin for R.

This is just a single line change in the README to resolve the message R is invalid. Name may only contain lowercase letters, numbers, '_', and '-':

asdf plugin-add r https://github.com/asdf-community/asdf-r.git
signus commented 1 year ago

Note that the hygiene check seems to be based on an outdated workflow that does not match with the current Makefile:

asdf-community/.github/.github/required-workflows/hygiene.yml

name: Hygiene

on:
  - pull_request

jobs:
  hygiene:
    name: Hygiene

    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v3

      - name: Set-up Homebrew
        uses: Homebrew/actions/setup-homebrew@master

      # Dependencies
      - run: brew install shellcheck shfmt

      # Check formatting with shfmt
      - run: make format-check

      # Check linting with shellcheck
      - run: make lint
flying-sheep commented 1 year ago

You need to also fix the example lines here: https://github.com/asdf-community/asdf-r/blob/f1e4b8b31bcbdbe36c852bd3696dfcdc247ea883/README.md#L40-L44

Should be asdf install r, not R