search

asdf-community / asdf-racket

Racket plugin for the asdf version manager
https://github.com/asdf-vm/asdf
Apache License 2.0
12 stars 6 forks source link

Fix incomplete installations #12

Closed nandalopes closed 8 months ago

nandalopes commented 10 months ago

If applied, this commit will use xargs to pass ./configure arguments.

Prior to this change, asdf install racket $version doesn't work properly because of an error in configure step, even if it ends with a success message.

Fix #10

smorimoto commented 10 months ago

Or it should work just by removing the double quotes. I feel like we have a good way about this, but I can't remember... Any idea? @vic

nandalopes commented 10 months ago

I figured out a solution reproducing install script step by step. Then I compared with other plugins and found some of them using xargs and <<< to pass install arguments.

nandalopes commented 10 months ago

Or it should work just by removing the double quotes. I feel like we have a good way about this, but I can't remember... Any idea? @vic

It doesn't pass shellcheck lint: SC2086 (info): Double quote to prevent globbing and word splitting.