search

asdf-format / asdf-coordinates-schemas

ASDF schemas for coordinates
https://asdf-coordinates-schemas.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Update schemas for ASDF standard 1.6.0 #55

Closed braingram closed 6 months ago

braingram commented 7 months ago

~As several schemas reference ndarray-1.1.0 (which is not yet in a released version of ASDF standard 1.6.0) this PR temporarily adds a dev requirement for asdf-standard (which can be removed after https://github.com/asdf-format/asdf-standard/pull/422 is merged and released).~ EDIT: asdf-standard 1.1.0 was released

braingram commented 7 months ago

The CI workflow disabled itself. I re-enabled it and closed/reopened to trigger the CI.

braingram commented 7 months ago

The asdf-astropy devdeps failure is due to the time changes in 1.6.0 in https://github.com/asdf-format/asdf-standard/pull/422 Once that PR is merged asdf-astropy can be updated to get time from the new astronomy manifest instead of core for 1.6.0.

braingram commented 6 months ago

CI passed with released asdf-standard and dev asdf-astropy (except for the noted time tests above due to the asdf-standard update for 1.6.0): https://github.com/asdf-format/asdf-coordinates-schemas/actions/runs/8163735550

I've removed the dev asdf-astropy testing requirement to allow merging this PR. This removal will cause CI failures (as the schemas in this package require asdf-astropy to be updated). Once this is merged and released, asdf-astropy can be updated to fix the errors.

The error (which stopped the CI): https://github.com/asdf-format/asdf-coordinates-schemas/actions/runs/8177206846/job/22358346903?pr=55#step:5:1927

E                   TypeError: ICRS() missing 1 required positional argument: 'dec' (or first argument should be an instance of UnitSphericalRepresentation).

during testing of resources/schemas/frames/galactocentric-1.1.0.yaml asdf-astropy fails to convert the tag:astropy.org:astropy/coordinates/latitude-1.1.0 used in the example. Which makes sense as it does not yet register the manifest (added in this PR) that adds that tag.