asdf-format / asdf-wcs-schemas

World Coordinate System (WCS) ASDF schemas
https://asdf-wcs-schemas.readthedocs.io/
Other
4 stars 5 forks source link

Clean up the wcs schemas #41

Closed WilliamJamieson closed 1 year ago

WilliamJamieson commented 1 year ago

This PR removes the wcs schemas and cleans up the gwcs schemas. The wcs schemas are in old versions of asdf-standard and #19 did not properly integrate them into asdf-wcs-schemas. This PR also:

braingram commented 1 year ago

Can these changes be made without the directory structure reorganization? The reorganization would make this package differ significantly from the other "asdf-*-schemas" repositories.

I'm currently working on converting all of these to a templated structure (as they all share many almost identical files) which would benefit from keeping them consistent.

WilliamJamieson commented 1 year ago

Can these changes be made without the directory structure reorganization? The reorganization would make this package differ significantly from the other "asdf-*-schemas" repositories.

I'm currently working on converting all of these to a templated structure (as they all share many almost identical files) which would benefit from keeping them consistent.

No it doesn't it makes it match the asdf-standard template, which is what is preferable.

WilliamJamieson commented 1 year ago

@braingram if you don't want to have the directory restructure, feel free to pop 5299b0d3510f13b61024bd6e486ea49f4d920b80 out of my commit stack and push a new branch.

nden commented 1 year ago

I would prefer to keep the old structure as well. There are historical reasons for that but at this point I think it'd be good to not reconfigure things all the time.

braingram commented 1 year ago

Thanks! Closing this as the changes in #45 and #46 are overlapping.