asdf-format / asdf

ASDF (Advanced Scientific Data Format) is a next generation interchange format for scientific data

http://asdf.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

523 stars 57 forks source link

fix masked array class path for numpy 2.0 #1769

Closed braingram closed 6 months ago

braingram commented 6 months ago

Numpy 2.0 moved the internal path for np.ma.MaskedArray. See: https://github.com/numpy/numpy/commit/7b9dede257171bdfafdd4a6fa43ac4df806b1103

This causes masked arrays to be saved as standard numpy arrays with a warning. See: https://github.com/astropy/asdf-astropy/actions/runs/8222457553/job/22484029609?pr=219#step:10:291

This PR updates the converter to be aware of the new path.

I believe https://github.com/asdf-format/asdf/pull/1654 would have prevented this failure (by allowing for the public class path).

Description

Checklist:

[ ] pre-commit checks ran successfully
[ ] tests ran successfully
[ ] for a public change, a changelog entry was added
[ ] for a public change, documentation was updated
[ ] for any new features, unit tests were added

braingram commented 6 months ago

Compatibility tests addressed in: https://github.com/asdf-format/asdf/pull/1771

braingram commented 6 months ago

Thanks!