asdf-format / asdf

ASDF (Advanced Scientific Data Format) is a next generation interchange format for scientific data
http://asdf.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
523 stars 57 forks source link

Deprecate `asdf.testing.helpers.format_tag` and `asdf.versioning.AsdfSpec` #1774

Closed braingram closed 5 months ago

braingram commented 6 months ago

Description

This PR deprecates asdf.testing.helpers.format_tag (and replaces it's one use with a string) and asdf.versioning.AsdfSpec (which is unused).

Fixes: #1773

Checklist:

braingram commented 6 months ago

The downstream dkist error is unrelated and looks to be caused by a gwcs version comparison in one of their tests.

braingram commented 5 months ago

Thanks!

The only docs I also see are the auto-generated ones: https://asdf.readthedocs.io/en/latest/search.html?q=format_tag&check_keywords=yes&area=default

I don't quite know the whole history of format_tag but looking through various git blames:

but never appears to be documented beyond the docstring and auto-generated docs. It seems to always have been a way to construct a uri string from several string (or AsdfVersion, when that was added) components.