asdf-format / asdf

ASDF (Advanced Scientific Data Format) is a next generation interchange format for scientific data

http://asdf.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

511 stars 56 forks source link

remove unused `_warn_tag_mismatch` and `_warned_tag_pairs` #1786

Closed braingram closed 3 weeks ago

braingram commented 2 months ago

These are unused as seen in the coverage (and searching the asdf and downstream code): https://app.codecov.io/gh/asdf-format/asdf/blob/main/asdf%2F_asdf.py#L1600

and appear to be related to the removed TypeIndex and could have been removed in: https://github.com/asdf-format/asdf/pull/1637

Checklist:

[ ] pre-commit checks ran successfully
[ ] tests ran successfully
[ ] for a public change, a changelog entry was added
[ ] for a public change, documentation was updated
[ ] for any new features, unit tests were added

braingram commented 3 weeks ago

The weldx failure is unrelated and due to numpy 2.0.