asdf-format / asdf

ASDF (Advanced Scientific Data Format) is a next generation interchange format for scientific data

http://asdf.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

523 stars 57 forks source link

handle junk bytes after tree #1822

Open zacharyburnett opened 1 month ago

zacharyburnett commented 1 month ago

Description

fixes https://github.com/asdf-format/asdf-standard/issues/441

[ ] junk before blocks (after tree) raises OSError: Invalid block magic https://github.com/asdf-format/asdf/blob/867c280fbba827fce27a977a2b6ead58abc6b319/asdf/_block/reader.py#L249-L257
[ ] junk after blocks (after tree) raises asdf.exceptions.AsdfBlockIndexWarning: Invalid block index contents for block 0, falling back to serial reading: Invalid block magic https://github.com/asdf-format/asdf/blob/867c280fbba827fce27a977a2b6ead58abc6b319/asdf/_block/reader.py#L258-L262

Checklist:

[ ] pre-commit checks ran successfully
[ ] tests ran successfully
[x] for a public change, a changelog entry was added
[ ] for a public change, documentation was updated
[x] for any new features, unit tests were added

zacharyburnett commented 1 month ago

we've decided to move these reference files to asdf-standard, and cover the following cases:

0 bytes
5 bytes