asdf-format / asdf

ASDF (Advanced Scientific Data Format) is a next generation interchange format for scientific data

http://asdf.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

523 stars 57 forks source link

skip dkist benchmarks #1837

Closed braingram closed 2 weeks ago

braingram commented 2 weeks ago

Description

dkist added benchmarks to their test suite in https://github.com/DKISTDC/dkist/pull/382

which they disable for unit test runs using --benchmark-skip

This PR adds the same skip to our downstream dkist test (which is otherwise failing on the benchmarks).

Checklist:

[ ] pre-commit checks ran successfully
[ ] tests ran successfully
[ ] for a public change, added a towncrier news fragment
changes/<PR#>.<changetype>.rst
- changes/<PR#>.feature.rst: new feature
- changes/<PR#>.bugfix.rst: bug fix
- changes/<PR#>.doc.rst: documentation change
- changes/<PR#>.removal.rst: deprecation or removal of public API
- changes/<PR#>.general.rst: infrastructure or miscellaneous change

[ ] for a public change, updated documentation

[ ] for any new features, unit tests were added

braingram commented 2 weeks ago

@Cadair is this the correct way to skip the benchmarks?

Cadair commented 2 weeks ago

I think so yeah.