search

asdf-vm / asdf-elixir

Elixir plugin for asdf version manager
https://github.com/asdf-vm/asdf
MIT License
473 stars 70 forks source link

Revert "Add auto install of hex and rebar" #91

Closed dobs closed 4 years ago

dobs commented 4 years ago

Reverts asdf-vm/asdf-elixir#89

For context: https://github.com/asdf-vm/asdf-elixir/issues/90

This revert doesn't attempt to fix the functionality introduced in asdf-vm/asdf-elixir#89, just roll it back to fix asdf install functionality until a proper fix is in place.

dobs commented 4 years ago

I'd have to dig into it, but my hunch is that the CI failure is due to the issue that this is attempting to resolve, not this revert itself.

Stratus3D commented 4 years ago

I'd have to dig into it, but my hunch is that the CI failure is due to the issue that this is attempting to resolve, not this revert itself.

If that is the case there must be something wrong with our build.

zgohr commented 4 years ago

From what I can tell, part of the test chain is to use the current version of the plugin. Since the current version install is broken (master) then the success of this branch can never be reached.

Stratus3D commented 4 years ago

You are right. I need to fix that as soon as possible.

Stratus3D commented 4 years ago

Thanks for the PR!

Stratus3D commented 4 years ago

FYI @tverlaan, your changes had to be reverted.

tverlaan commented 4 years ago

Thanks, sorry for the trouble and I'll look into it myself as well.