asdf-vm / asdf-plugins

Convenience shortname repository for asdf community plugins
https://github.com/topics/asdf-plugin
MIT License
1.24k stars 483 forks source link

Remove all test failed plugins from the README #183

Open smorimoto opened 4 years ago

smorimoto commented 4 years ago

We are currently considering removing all test failed plugins from the README. Do you have the bandwidth to fix so that the test runs correctly again. Whether you have bandwidth or not, we recently started a collaborative, community-driven project called asdf-community for long-term maintenance of asdf plugins, so consider moving your plugins here. https://github.com/asdf-community/.github

I'm tagging all the authors of the related plugin (in no particular order), but I'd like to hear everyone's opinions.

smorimoto commented 4 years ago

CC: @blimmer (Ibotta/asdf-brig)

smorimoto commented 4 years ago

CC: @nickveys, @gabecook (code-lever/asdf-rust)

smorimoto commented 4 years ago

Of course, I can help you run the test correctly again.

sylph01 commented 4 years ago

I do recognize that there are issues for newer versions of mongodb, but its fix is not trivial, and I cannot work on fixing it right away. As such, please remove asdf-mongodb for now, and I will contact you again after fixing it.

smorimoto commented 4 years ago

@sylph01 OK. I'm looking forward to your contact.

odarriba commented 4 years ago

I currently don't have bandwidth to maintain asdf-php in any of the ways I would like to (new versions, optimisations, PHP extensions or fixing the tests), so I would agree to transfer it to this community if it starts moving and maintaining this kind of projects.

smorimoto commented 4 years ago

@odarriba We already manage a lot of plugins, for example the Standard ML plugin has been transferred by the author. If you okay, I will send you an invitation to prepare for the transfer.

odarriba commented 4 years ago

@imbsky let's transfer it then!

smorimoto commented 4 years ago

@odarriba Sent!

marciogm commented 4 years ago

hey @imbsky. I'm willing to transfer the asdf-crystal as well, could you send a invitation?

nickveys commented 4 years ago

@imbsky Just got asdf-rust fixed up, all green! Thanks for the reminder.

smorimoto commented 4 years ago

@marciogm Sent!

smorimoto commented 4 years ago

@nickveys Thank you! Really quick work!

smorimoto commented 4 years ago

I fixed the asdf-crystal's CI and dealt with all issues.

blimmer commented 4 years ago

@imbsky it looks like there's some kind of issue with Travis CI's badge on that repo. The tests are actually passing, even though the badge says that they're not:

Screen Shot 2020-01-26 at 8 27 03 AM

I opened https://github.com/Ibotta/asdf-brig/issues/8 to see if they can fix up the badge, as I no longer have maintainer abilities on that repo.

smorimoto commented 4 years ago

Thank you for checking! Hmm, that's weird... We've created a great tool for GitHub Actions, so it might be a good idea to move to it. https://github.com/asdf-vm/actions

blimmer commented 4 years ago

Sounds good. I opened https://github.com/Ibotta/asdf-brig/issues/9 for them to consider, since I don't have maintainer privs anymore. Thanks!

smorimoto commented 4 years ago

@blimmer Thank you again for your quick response!

ndac-todoroki commented 4 years ago

@imbsky Sorry for being late, I've fixed asdf-v. Thanks for the reminder!

smorimoto commented 4 years ago

@ndac-todoroki Great!

michaelstephens commented 4 years ago

As a whole I think asdf community is a great thing, I'd be happy to pass asdf-elasticsearch off to that

smorimoto commented 4 years ago

@mikestephens I sent you an invitation!

mtatheonly commented 4 years ago

@imbsky Fixed the asdf-scala plugin =)

smorimoto commented 4 years ago

@mtatheonly Thank you!

vic commented 4 years ago

Nice, I'll also try fixing mines this weekend and transfer them.

smorimoto commented 4 years ago

Awesome! By the way, most plugins have been fixed by the author or community maintainer. Thanks to everyone who helped us.

particledecay commented 4 years ago

Selection_762 This plugin was renamed to "Talos" per #151. Sorry... should have removed osctl. I can submit another PR to remove it.

smorimoto commented 4 years ago

@particledecay All right!

smorimoto commented 4 years ago

I just setup GitHub Actions on asdf-php in https://github.com/asdf-community/asdf-php/pull/31!

smorimoto commented 4 years ago

I also added CI setup to elasticsearch.

richin13 commented 4 years ago

Sorry for the late response, asdf-neovim is now green

smorimoto commented 4 years ago

@richin13 No worries! Thank you!

vic commented 4 years ago

asdf-graalvm is green again.

smorimoto commented 4 years ago

Thanks!

elementalvoid commented 4 years ago

Oh dang. I missed this one -- I can help out with asdf-brig (hey @blimmer!)

Since Ben was the only contributor no one @ibotta got a notification of the issue he made for us. I've set myself as a watcher and will be fixing the build very soon.

elementalvoid commented 4 years ago

asdf-brig has been fixed!

GitHub Actions Status

smorimoto commented 4 years ago

Thanks!

yozachar commented 1 year ago

I think, this can be automated..

jthegedus commented 1 year ago

I don't want to remove plugins automatically. GitHub checks have intermittent failures more frequently than I enjoy.

I did update the CI so commits on the default branch tests all plugins and summarizes the information. For example:

 * Checking plugins/vendir [FAILED]
*   FAIL: Expected plugin CI badge SVG to be passing but it was not: https://github.com/vmware-tanzu/asdf-carvel/workflows/test-all/badge.svg
* Checking plugins/ytt [FAILED]
*   FAIL: Expected plugin CI badge SVG to be passing but it was not: https://github.com/vmware-tanzu/asdf-carvel/workflows/test-all/badge.svg

Plugins available: 638
Plugin build checks passed: 549
Plugin build checks failed: 89

source - https://github.com/asdf-vm/asdf-plugins/actions/runs/4751694153/jobs/8441129580

I think there are ways to further automate this and report to the authors that there are issues, whether by tagging them in a thread in this repo or by opening Issues in the plugin repos. However, I don't feel the effort is worth the reward.

Very few people seem to complain about plugins actually not working. It's only a few times a year that we replace unmaintained plugins with new forks. Although some of the repos here might not work, they give people a place to fork from and then we can update this repo with their new plugins.

This is a health check at best. It isn't, and shouldn't, be a tool for people to gauge plugin health, robustness or trust. I try to point this out as much in this repo's README, SECURITY file and core tool documentation site.

yozachar commented 1 year ago

I agree, not removing plugins directly, instead automating the notification of failed builds, with a warning of grace time, say 3 to 6 months to fix the build. It's more of a maintenance status check, and yeah I also doubt if it's worth the effort.