Determined version from latest release

marocchino commented 1 year ago

I tried implementing #319 This implementation assumes that the ruby-build's latest release is always used.

KelseyDH commented 1 year ago

Any problems with this PR preventing it from merging? Ruby 3.2.1 stable just got released today and ASDF doesn't have it yet!

jdx commented 1 year ago

I merged this into rtx-ruby which may work inside of asdf if anyone wants to use this

Stratus3D commented 1 year ago

Closing this for now. See https://github.com/asdf-vm/asdf-ruby/issues/319 for explanation. I know this is a highly requested feature, but please keep the following things in mind:

A hard coded ruby-build version that must be bumped is what the Homebrew package manager does (see https://github.com/Homebrew/homebrew-core/blob/4aa8e6d17a8fbf44ff8033d5eb799c9e1e1483e2/Formula/ruby-build.rb#L4)
Anyone can override the hard coded version at any time by setting the ASDF_RUBY_BUILD_VERSION variable in your shell to master or any tag (export ASDF_RUBY_BUILD_VERSION=master).
Anyone is free to fork this repo and create another version of it containing this feature or different code entirely (as @jdxcode has done).

Thank you @marocchino for taking the initiative to make these changes, hopefully I'll have a more automated solution to this in the future that satisfies our criteria.

asdf-vm / asdf-ruby

Determined version from latest release #320