asdf-vm / asdf-ruby

Ruby plugin for asdf version manager
https://github.com/asdf-vm/asdf
MIT License
657 stars 133 forks source link

Ruby 3.2.0 is in stable release, i can't find the list for ruby 3.2.0 stable in asdf list-all ruby #329

Closed ariandanim closed 1 year ago

ariandanim commented 1 year ago

Dear team,

Please make ruby 3.2.0 available in list-all ruby asdf, i see only 3.2.0 preview 3 in those list

choosen commented 1 year ago

https://github.com/asdf-vm/asdf-ruby/pull/322

jcouball commented 1 year ago

Try running asdf plugin update ruby.

$ asdf version
v0.11.1
$ asdf plugin update ruby
Updating ruby to master
Already on 'master'
Your branch is up to date with 'origin/master'.
$ asdf list all ruby | grep '3.2.0'
3.2.0-dev
3.2.0-preview1
3.2.0-preview2
3.2.0-preview3
3.2.0-rc1
3.2.0
jruby-9.3.2.0
$
KelseyDH commented 1 year ago

It's weird that you have to run asdf plugin update ruby, I was expecting asdf update to load the list of new ruby versions but it didn't.

KelseyDH commented 1 year ago

FYI Ruby 3.2.1 is now in stable release also. When will that get added to asdf ruby? I see a PR merged for it but not finding it after asdf plugin update ruby

=> asdf plugin-update ruby
Updating ruby to master
Already on 'master'
Your branch is up to date with 'origin/master'.

=> asdf install ruby 3.2.1
Version not found

=> asdf latest ruby
3.2.0

UPDATE: I see it has been added. :)

choosen commented 1 year ago

@KelseyDH it seems to plugin responsibility to handle updates per plugin. I would have control on update: should it be only asdf engine or plugins also. So maybe asdf update --plugins ? or some config for it ? :P

pboling commented 1 year ago

It would be cool if, like homebrew, asdf ruby would auto update sporadically. Until then we must manually update the plugin.

saraid commented 1 year ago

It's really not asdf-ruby's responsibility to make those decisions. It's just a plugin for asdf-vm. If you want these enhancements, maybe suggest them on https://github.com/asdf-vm/asdf/issues ?

SeanSith commented 1 year ago

Agreed. @ariandanim this functionality does belong there. Can you close this and create an issue over there?

choosen commented 1 year ago

asdf plugin-update --all seems to be the command , or just the plugin ? waiting for ruby 2.7.8 to be released in ruby-build.

If just the plugin then can we automatically fire up the command asdf plugin ruby update ?

saraid commented 1 year ago

@choosen asdf plugin-update --all appears to be defined here:

https://github.com/asdf-vm/asdf/blob/8919f4009ea233c32298911b28ceb879e2dbc675/lib/functions/plugins.bash#L116-L123

choosen commented 1 year ago

so we have hook named : post_asdf_plugin_update and we can add most probably function to update ruby-build (asdf plugin ruby update)

BTW. ruby build was released with 2.7.8 already: https://github.com/rbenv/ruby-build/releases/tag/v20230330

Nodejs is fetching builder on:

vladalive commented 1 year ago

asdf plugin update --all

Stratus3D commented 1 year ago

Closing because #322 has improved the error message. Further discussion of this should be continued under https://github.com/asdf-vm/asdf-ruby/issues/319.