Open topalovic opened 10 months ago
Hello, I run into this today, does this accept PR or maintained or whatever?
I'm not sure I'm a fan of asdf managing the concurrency settings. What if a user wants to use different settings Ruby and another setting for another asdf plugin?
In any case a user has to set something, either:
export MAKE_OPTS="-j <cores>"
export ASDF_CONCURENCY="<cores>"
Thoughts?
Hey @Stratus3D.
I'm not sure I'm a fan of asdf managing the concurrency settings
The official docs suggest that it should be supported:
https://asdf-vm.com/manage/configuration.html#concurrency
Note: the environment variable ASDF_CONCURRENCY take precedence if set.
If the plugins don't observe it, then there is no point in its existence, I suppose.
What if a user wants to use different settings Ruby and another setting for another asdf plugin?
It should be as simple as you suggest, no?
$ export ASDF_CONCURRENCY=<cores>
$ asdf install ruby
To clarify why I'm asking about this setting. The default options set MAKE_OPTS="-j $(num_cpu_cores)"
which makes the recent i9 i13900 CPUs unstable and prone to segfaults. Only after reducing concurrency to -j 16
was I able to compile Ruby using asdf and rbenv.
If major plugins such as asdf-ruby do not intend to support ASDF_CONCURRENCY
, perhaps it should be removed from the official docs.
First of all, thank you for all the hard work so far.
I would like to inquire about support for
ASDF_CONCURRENCY
. Unless I'm missing something, it looks it was added in https://github.com/asdf-vm/asdf-ruby/commit/77df296, but then got lost during the transition toruby-build
.Do you think we could reintroduce it by passing the value to
ruby-build
asMAKE_OPTS
? I'm hoping it is as simple as exporting before the build command: