asdf-vm / asdf

Extendable version manager with support for Ruby, Node.js, Elixir, Erlang & more
https://asdf-vm.com/
MIT License
21.87k stars 777 forks source link

Support plugin install giturl#gitref #1201

Open airtonix opened 2 years ago

airtonix commented 2 years ago

Is your feature request related to a problem? Please describe

i'm always frustrated with i have to fill these things out.

lets support installing asdf plugins from a git repo with a gitref (tag, branch, commit)

Describe the proposed solution

asdf plugin install https://github.com/heliumbrain/asdf-just#6cc5790

Describe similar asdf features and why they are not sufficient

  1. cajole broken plugin author into fixing their code
  2. get stonewalled there
  3. fork the broken plugin repo
  4. fix the code
  5. remove old broken plugin
  6. point at different repo

lets say the author fixes their code, but then later on decides to change things...

the only way i can guard the onboarding process of my team is to fork every asdf plugin and use those repos instead.

Describe other workarounds you've considered

crying.

jthegedus commented 2 years ago

For reference, plugins do support updating to a specific branch or git tag:

From asdf help:

asdf plugin update <name> [<git-ref>]   Update a plugin to latest commit on
                                        default branch or a particular git-ref

Used as:

asdf plugin add firebase https://github.com/jthegedus/asdf-firebase
# update to specific tag
asdf plugin update firebase v1.1.0
# or with a sha
asdf plugin update firebase 57f29ec

1204 will obviously make this easier and require a single step

ChadRehmKineticData commented 1 year ago

What is the current status of this issue? Is there a consideration for adding gitref support?

hyperupcall commented 1 year ago

Hi @ChadRehmKineticData, this is a community run project. Maintainers of this project are volunteers and work in their spare time to contribute.

If you want to increase the priority of the issue, feel free to upvote the original post so the maintainers can properly gauge interest.

There doesn't seem to be anyone voicing negative support for this feature, so I'd say that if a PR adds support, It'll likely get added. Unfortunately, there is a backlog of PRs and it doesn't seem like they are being resolved anytime soon. So there is consideration, but it is up for someone themselves to add support, which may take a while to eventually merge.