search

asdf-vm / asdf

Extendable version manager with support for Ruby, Node.js, Elixir, Erlang & more
https://asdf-vm.com/
MIT License
21.14k stars 763 forks source link

fix: keep_download condition #1721

Open Birdie0 opened 4 months ago

Birdie0 commented 4 months ago

Summary

Swap directory and argument checks so it won't result in misleading warning.

Fixes: #1711

Other Information

Also replaced [ ! a = b ] with [ a != b ] as it's more readable. Inverted condition for better readability.

hyperupcall commented 4 months ago

Thanks - I'll take a look at this soon. I made the original PR and want things to pass the additional test cases I added in an offline branch

Birdie0 commented 2 months ago

@hyperupcall Any luck?

hyperupcall commented 2 months ago

@Birdie0 Unfortunately, I can no longer boot up the computer that had those test cases. Until I am able to diagnose and fix it, I won't be able to check.

But your changes look good to me and if anything, is likely to be more correct than the existing logic anyways. I don't think my personal issues is blocking your PR. I'm not a maintainer or anything, but these days it seems more difficult to get PRs in, which is why this is isn't already merged yet, and why I have closed many of my existing PRs.