Closed C0deBr3ak3r closed 2 months ago
lines: 237 up to 246 in file lib/functions/installs.bash
....
# Remove download directory if --keep-download flag or always_keep_download config setting are not set
always_keep_download=$(get_asdf_config_value "always_keep_download")
if [ ! "$keep_download" = "true" ] && [ ! "$always_keep_download" = "yes" ]; then
if [ -d "$download_path" ]; then
rm -r "$download_path"
else
printf '%s\n' "asdf: Warn: You have configured asdf to preserve downloaded files (with always_keep_download=yes or --keep-download). But" >&2
printf '%s\n' "asdf: Warn: the current plugin ($plugin_name) does not support that. Downloaded files will not be preserved." >&2
fi
fi
...
It's checking if keep_download
is not equal to true
nor yes
and tries to remove the directory, however if the directory does not exist it shows the warning, the warning should be behind a check to see if the option is set
Oh sorry, duplicate of #1711 . Closing it
Describe the Bug
A warn is show stating that you have set the option
always_keep_download
toyes
or used the option--keep-download
while neither of those where set. The bug is in filelib/functions/installs.bash
at line 239Steps to Reproduce
always_keep_download
tono
inasdfrc
Expected Behaviour
The warning message shouldn't be trigger
Actual Behaviour
A warning message for unsupported option
always_keep_download
in plugin is triggeredEnvironment
asdf plugins affected (if relevant)
No response