asdf-vm / asdf

Extendable version manager with support for Ruby, Node.js, Elixir, Erlang & more

https://asdf-vm.com/

MIT License

21.14k stars 763 forks source link

fix: Only display the "can't keep downloads" warning when asked to keep downloads #1756

Open benblank opened 1 month ago

benblank commented 1 month ago

Summary

Currently, the warning which is intended to alert users that the download directory can't be kept only appears if they haven't asked for it to be. This fix just rearranges the logic a bit so that the warning instead only appears if the download directory should be kept, but can't be (because it doesn't exist).

Fixes: #1711

fharper commented 39 minutes ago

Any ETA on merging this PR? Not critical, but it's there :)