asdfjkl / jfxchess

JFXChess - Chess Program
https://asdfjkl.github.io/jfxchess
GNU General Public License v2.0
102 stars 21 forks source link

Misleading mate annotation #56

Closed futurelauncher closed 4 years ago

futurelauncher commented 4 years ago

Hi! After completing "Full Analysis" (with the engine, of course), scores given to each move show # (mate) but never show who is mating who. For e.g. jerry bug In the above image, if you come to Black's move no. 25 (as well as 27 and 29), { #10 } score is shown which means White is mating Black, but actually Black is mating White. { # -10 } would be more appropriate (adding minus sign in the score for Black).

asdfjkl commented 4 years ago

thanks for spotting. It seems that most programs use { - #10 } (i.e. like { - 1.243 }. I will fix this in the next version.

futurelauncher commented 4 years ago

Just for the sake of information, Scid Vs Pc is using a different approach. It uses some value above 300 in case of mate. In above case, it shows { - 327.60 }. I don't know how this no. is calculated. Probably 300 for the King in addition of other pieces.

asdfjkl commented 4 years ago

should be fixed in version 4. uses - sign.