search

asdfjkl / jfxchess

JFXChess - Chess Program
https://asdfjkl.github.io/jfxchess
GNU General Public License v2.0
102 stars 21 forks source link

Removed checked in target directory. #96

Closed mipper closed 3 years ago

mipper commented 3 years ago

This directory is automatically created and populated by maven and should not be checked in.

Looks like the has been tried before but may not have worked as the files are still present in the remote repo.

asdfjkl commented 3 years ago

Thanks for your contribution! But could you help me by describing briefly what happened in "Encapsulate UCI engine."? Bugfixes?

asdfjkl commented 3 years ago

I do appreciate your effort in rewriting the engine-code, but i am rejecting this. I will handpick changes from your code. But right now, after merging I get this when I stop an already running engine:

java.io.IOException: Die Pipe wird gerade geschlossen (pipe is currently closing) at java.base/java.io.FileOutputStream.writeBytes(Native Method) at java.base/java.io.FileOutputStream.write(FileOutputStream.java:347) at java.base/java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:81) at java.base/java.io.BufferedOutputStream.flush(BufferedOutputStream.java:142) at java.base/sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:327) at java.base/sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:159) at java.base/java.io.OutputStreamWriter.flush(OutputStreamWriter.java:251) at java.base/java.io.BufferedWriter.flush(BufferedWriter.java:257) at org.asdfjkl.jerryfx.gui.UciEngineProcess.send(UciEngineProcess.java:30) at org.asdfjkl.jerryfx.gui.EngineThread.processCommand(EngineThread.java:191) at org.asdfjkl.jerryfx.gui.EngineThread.serviceQueue(EngineThread.java:106) at org.asdfjkl.jerryfx.gui.EngineThread.run(EngineThread.java:76)

mipper commented 3 years ago

Apologies - I wasn't supposed to have pushed the re-encapsulation code; that wasn't finished. The PR was only supposed to be for removing the target directory which is totally generated by maven during a build. If there's stuff I pushed by accident that you find useful, obviously, help youself. I should also add, I missed your original question. Spam folder shinanigans.

asdfjkl commented 3 years ago

Thanks for the reply! Looking at the changes, I already removed target dir, thx for spotting!