update for go module compatibility

asdine / storm

Simple and powerful toolkit for BoltDB

MIT License

2.06k stars 139 forks source link

update for go module compatibility #246

Closed Xe closed 5 years ago

Xe commented 5 years ago

Update internal imports for Semantic Import Versioning compatibility. I realize this is dumb and means existing code needs to be updated or you could import two versions of storm. This is the state of the world with Go modules.

Please make a semver patch bump.

anjmao commented 5 years ago

I think it's better to close this and merge https://github.com/asdine/storm/pull/256 as v2 is already released so it can break consumers who already uses v2.

chappjc commented 5 years ago

I had completely forgotten about this PR, but I agree with @anjmao regarding /v3. The reasoning is outlined in https://github.com/asdine/storm/issues/255 and the linked docs from there.