asdlei00 / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

CrashSender.exe crashes when attempting to write long strings into NOTIFYICONDATA #137

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
CrashSender.exe crashes in ResendDlg:611 if the string generated in line 610 is 
longer than 64 (63?) characters:
Problem description:
sTip.Format(Utility::GetINIString(g_CrashInfo.m_sLangFileName, _T("ResendDlg"), 
_T("DlgCaption")), g_CrashInfo.m_sAppName);

=> A long application name and/or a long entry [ResendDlg]/DlgCaption in 
crashrpt_lang.ini (en: "%s - Send Error Reports") can cause these conditions.

My environment:
CrashRpt 1.2.9 -- I diffed against version 1.3.0 but the code in question has 
not changed, so I suppose it is still valid.
Visual Studio 2008
Windows XP

Patch:
The attached patch checks for the length of the resulting string before copying 
it into the NOTIFYICONDATA object. If it's too long, the string is shortened 
using an ellipsis.

Original issue reported on code.google.com by colegar...@googlemail.com on 6 Mar 2012 at 10:33

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by zexspect...@gmail.com on 12 Mar 2012 at 10:37

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r1343.

Original comment by zexspect...@gmail.com on 25 Aug 2012 at 12:42