As the code is probably viewed with a variety of source editor settings it
would help if white-space would be just tabs (or just spaces).
Currently it seems like there is a mixture which displays fine when the tab
size is set to two characters but becomes difficult to read when it is set to
e.g. 4 spaces.
Using tabs would allow everyone to keep their settings.
Also CString::GetBuffer(0) (which gives an LPTSTR) is used in many places
instead of the cast operator to obtain an LPCTSTR.
While this is no bug and possibly has no impact in all the places it can make
code more inefficient (as it may force re-allocation in case there is another
reference to the string object) and is less readable (as it is not clear right
away that the string object is not modified).
Original issue reported on code.google.com by asch...@gwdg.de on 30 Jun 2011 at 10:35
Original issue reported on code.google.com by
asch...@gwdg.de
on 30 Jun 2011 at 10:35