search

asearfos / chipper

Software (with Kivy GUI) for semi-automated segmentation and analysis of birdsongs or other acoustic signals.
GNU General Public License v3.0
10 stars 6 forks source link

fix reset parameters when using previous gzips #27

Closed asearfos closed 5 years ago

asearfos commented 5 years ago

if reset parameters, they currently go to the ones the user input; if parameters were found from a previously chippered gzip, they should go back to those instead (not sure how to do this without adding params as a self variable)

asearfos commented 5 years ago

Need to test this, have vague memory that this may have been completed already.

asearfos commented 5 years ago

this is still not resolved. Works with "back button" but not "reset parameters".

Also noted when old parameters are used and onsets and offsets had been manually added (the first time it was chippered) then now when parameters are altered using the sliders all manually added onsets and offsets are gone. This happens also with bouts not previously chippered - manual entry must be last. This may not need to be fixed but was confusing to me as a user when loading previously chippered files (took me a while to figure this out).

asearfos commented 5 years ago

Changed button text from "Reset Parameters" to "Default Parameters" to make it clear this button will not load the parameters from the gzip.

JamesPino commented 5 years ago

Which one takes priority? The one from a previous gzip? Or if a user clicks save, then goes back, do the ones that were saved win out? Once there is a priority and logic to which ones win out, it should be easy to fix. Also, should there be two buttons? Hard reset or something?

asearfos commented 5 years ago

I was just thinking maybe we would want the "Reset/Default Parameters" to go back to the parameters (and any manual onsets and offsets) loaded from the gzip. This would be similar to just going to defaults for one without a gzip. So if submit is hit, currently the back button loads those onsets/offsets and parameters (which is correct) but then if the reset parameters is hit it goes to how it loads into chipper the first time (which is also correct). For gzips it resets to defaults not the ones it first loaded into chipper with.

Not sure if this makes sense but I am thinking maybe it is best the way it is actually. And changing the wording just makes it more clear what is happening.