search

aseba-community / aseba

Aseba is a set of tools which allow beginners to program robots easily and efficiently. To contact us, please open an issue.
http://aseba.wikidot.com
GNU Lesser General Public License v3.0
49 stars 61 forks source link

VPL Sensor event "between" values #345

Closed motib closed 9 years ago

motib commented 9 years ago

Currently a sensor event is caused in advanced mode in VPL if the value read is below the value specified in the lower slider or above the value specified in the upper slider. I request an option for an event when the value is between the sliders. I found my self needing this when trying to implement something similar to the lightpainting project in VPL.

stephanemagnenat commented 9 years ago

This is an interesting idea. As I see it, it should be another colour (currently gray is ignore, white is close, red is far), maybe blue?

I have moved the timer to the advanced mode, as we discussed. Now I am afraid the advanced mode has too many thing, should we have three modes in total?

motib commented 9 years ago

I guess you mean black not red. You could re-use the red now, but blue is probably a better idea so as not to confuse it with the old red.

I don't find advanced mode confusing, only three new types of blocks (timers, states, accelerometers) plus sliders on the sensors. I would leave the extra modes for further research.

stephanemagnenat commented 9 years ago

Yes I meant black, sorry for the confusion.

I have implemented it in commit 79ac39c607e25dd18335b27fc0110ecf081c2659, using the colour yellow.

As soon as the build server is back up, you can test that and tell me if you think it is worth having.

ddoak commented 9 years ago

Not sure how to report this. I believe it is associated with this commit but I don't know how to get the commit reference from my Homebrew version.

On my current "brew install --HEAD aseba" version (OSX) I have a 100% reproducible VPL crash when clicking on the leds on the sensor event blocks.

Repro Steps:

enter VPL advanced mode add sensor event block click on led (until colour cycles to black) next click on led crashes with following assert

Assertion failed: (false), function updateIndicationLEDsOpacity, file /tmp/aseba-cXepCE/clients/studio/plugins/ThymioVPL/Block.cpp, line 680

stephanemagnenat commented 9 years ago

Yes you are right, I forgot to update this function. It should be fixed in commit f44b6ae036db327935a39db4cf6bc4ee0d9bb7e4. Thanks a lot for testing and reporting!

ddoak commented 9 years ago

I've just had a play around with the 'ranged' sensor blocks in advanced VPL. There is a lot of new (for me) functionality and I can see that the interface design is challenging.

I've got some opinions about how I think the interface could be improved and I think they'd be reasonably sympathetic to the underlying code. i.e. not too much work!

Is this the right place to post them? I don't want to be too pushy with unsolicited design advice ;)

stephanemagnenat commented 9 years ago

At some point we plan to setup a proper structure for collecting user feedback, but until then, for all Aseba and VPL-related suggestions, feel free to use this issue tracker. Feel free to open a new issue to discuss the proposed changes, and tag it with "Thymio VPL" and "Wish".

Thank you very much for your interest in Thymio/VPL/Aseba!

stephanemagnenat commented 9 years ago

Actually, maybe the best way to have a discussion is to use our mailing list. We have three in English:

For this specific point, I think tha aseba-thymio is the most relevant one.

ddoak commented 9 years ago

Stéphane - apologies, I missed your last comment as I was editing the new issue. I haven't tagged it yet - I can't see how to!

stephanemagnenat commented 9 years ago

@motib this is now implemented with a color coding similar to what @ddoak suggested in issue #347 . As usual, testing is welcome :-)

stephanemagnenat commented 9 years ago

@motib please close this issue if you are happy with the current implementation.