aseba-community / thymio-vpl2

Next generation VPL for Thymio using Qt Quick from Qt 5.x
GNU Lesser General Public License v3.0
2 stars 5 forks source link

Duplicate parametrized events on different lines are not detected #113

Closed stephanemagnenat closed 6 years ago

stephanemagnenat commented 7 years ago

If the same set of events with the same parametrization appear on two different lines, this error is not currently detected:

screen shot 2017-08-03 at 13 36 14

In this case, VPL1 shows a red line with linking the two faulty lines:

screen shot 2017-08-03 at 13 43 28
marvelous commented 7 years ago

By default, we'll compare the params value and leave open the possibility for the block to do more exhaustive checks.

marvelous commented 6 years ago

As per #116, we should only detect the case where the events are the same (not every possibly overlapping case) and there are conflicting actions.