search

aseba-community / thymio-vpl2

Next generation VPL for Thymio using Qt Quick from Qt 5.x
GNU Lesser General Public License v3.0
2 stars 5 forks source link

Line highlighting upon execution is not very visible in light-color theme #114

Closed stephanemagnenat closed 6 years ago

stephanemagnenat commented 6 years ago

Based some tests in a demonstration settings in Bordeaux, it looks like the current line execution highlighting is not very visible in light-color theme (but it is good in dark theme). The reason is that the contrasts between the line background and the yellow border is low.

For the highlight feature VPL1 shows a rectangle on the left side of the line, maybe adding this, or changing the border width or color, could help.

stephanemagnenat commented 6 years ago

I have tried darkening the highlight color in light theme, but it is ugly, although more visible.

stephanemagnenat commented 6 years ago

Commit 033aa85 fixes this issue by using middle green instead of bright yellow. It looks ok, not perfect, but for now it is usable.

stephanemagnenat commented 6 years ago

Commit fd999fe uses instead a violet with similar hue as the run button and the dark theme background.