search

aseba-community / thymio-vpl2

Next generation VPL for Thymio using Qt Quick from Qt 5.x
GNU Lesser General Public License v3.0
2 stars 5 forks source link

Blocks should not have a violet layer #61

Closed stephanemagnenat closed 7 years ago

stephanemagnenat commented 7 years ago

Because of visual compatibility with original test advanced mode, blocks in reactive mode have a violet layer around them, highlighting in yellow when they are executed. As the new FSM mode will have show different information (see #51), and the whole pair will be highlighted (see #38), this visual is now irrelevant.

marvelous commented 7 years ago

We still have the case where the block has a red ring, indicating an error (for example with #10).

stephanemagnenat commented 7 years ago

Can we do the same as in VPL1? For instance using a small arrow below the offending blocks? As far as I have observed and been told, VPL1 is very usable and easy to understand regarding these.

marvelous commented 7 years ago

Ok! I just discovered that the yellow highlight ring also appears when dragging a block over an other block. Should I remove that case as well?

stephanemagnenat commented 7 years ago

What is important is to have a visual feedback indicating potential drop. In VPL1, the dotted square become full to indicate that, and an existing block has some added elements on top and bottom to indicate potential drop. I think that a similar approach can be used. The exact visuals are not as important as their function. Of course, they should look clean and match the rest of the style. I suggest you have a look at VPL1 (you can use the simulator if you do not have a Thymio, or asebadummynode and launch thymiovpl with the -anytarget command line option).

marvelous commented 7 years ago

I looked at VPL1 and prefer the highlight we currently have in VPL2: it's the same yellow ring when dragging over a placeholder and when dragging over an existing block. So I'll leave the yellow ring.

As for errors, I prefer the red circle around the blocks that have an issue rather than the whole line being in red. I don't see the case where an error is for the whole line. It's always about some blocks. We can add the other error markers (exclamation point and connecting arrow) later.