aseba-community / thymio-vpl2

Next generation VPL for Thymio using Qt Quick from Qt 5.x

GNU Lesser General Public License v3.0

2 stars 5 forks source link

Move files around #96

Closed marvelous closed 7 years ago

marvelous commented 7 years ago

35#issuecomment-293290663

stephanemagnenat commented 7 years ago

Great! I have two small questions:

Should we also move the .cpp/.h files from the top-level to an src/ subdirectory?
The source translation files are in translations/ in the top-level while the generated .qm files are within the thymio-vpl2 sub-directory. As translations are generated through thymio-vpl2.pri, I am wondering whether the .ts files won't be better inside the thymio-vpl2 sub-directory.

marvelous commented 7 years ago

no, stop splitting by file type
yes, I suppose

stephanemagnenat commented 7 years ago

Agreed not to split files by type, so these two questions are actually a single one: shouldn't all implementation files that are part of the thymio-vpl2 library be in that sub-folder, rather than only the ones going into the resources? That would include the .cpp/.h files and the translation sources. Within the thymio-vpl2 subfolder, we could add more structure if need, such as creating a widget directory for things like FloatingActionButton.qml or, for example, a directory for the editors.