Open GoogleCodeExporter opened 9 years ago
I think it would be good if the message/build breaker text was smaller than the
project name, do you think?
Original comment by spurrymo...@gmail.com
on 16 Dec 2008 at 11:52
maybe, suppose there are 5 people breaking a build, the message can indeed be
long,
but the idea is to easily see who broke a build, and adjusting the font size
for the
message may make it unreadable. Or did you have another solution in mind?
Original comment by ruben.wi...@gmail.com
on 16 Dec 2008 at 11:58
Yeah, I'll have to see how it works in our situation. Maybe it's best how it
is. Or
maybe just have the message in a different color or something.
Original comment by spurrymo...@gmail.com
on 16 Dec 2008 at 10:24
Thanks for the patch, by the way.
The other question about how we should implement this is:
Do we want to show "multiple" people breaking builds?
Only 1 person breaks the build at 1 time, to my mind.
Any subsequent commiters are just victims ;-) Or do you mean something else by
"5
people breaking a build"
Original comment by spurrymo...@gmail.com
on 17 Dec 2008 at 6:11
Hi
about the multiple breakers : that depends on your setup.
If you do CI, there will be generally only 1 person breaking a build.
but if suppose you only do nightly builds, you aggregate all modifications of
that
day, and so there can be multiple people who contributed. Hopefully only one of
them
broke the build, but it is nice to now who modified the code, because these
people
are the ones knowing what the changed (they should know anyway;-) )
Also for the CI setup, if someone else besides the breaker wants to fix a
build, but
fails to do so, their both names are now shown. Hopefully this clears it out.
Original comment by ruben.wi...@gmail.com
on 17 Dec 2008 at 7:25
Original issue reported on code.google.com by
ruben.wi...@gmail.com
on 16 Dec 2008 at 10:42Attachments: